From e0e54965df015b954d75ebe945221372f2dffb80 Mon Sep 17 00:00:00 2001 From: Laurent Pinchart Date: Sun, 9 Oct 2022 07:34:09 +0300 Subject: libcamera: base: utils: Drop defopt utils::defopt causes compilation issues on gcc 8.0.0 to gcc 8.3.0, likely due to bug https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86521 that was fixed in gcc 8.4.0. gcc 8.3.0 may be considered old (libcamera requires gcc-8 or newer), but it is shipped by Debian 10 that has LTS support until mid-2024. As no workaround has been found to fix compilation on gcc 8.3.0 while still retaining the functionality of utils::defopt, remove it from the libcamera base library. This change could be reverted once support for gcc-8 will be dropped. Signed-off-by: Laurent Pinchart Reviewed-by: Jacopo Mondi Reviewed-by: Kieran Bingham --- include/libcamera/base/utils.h | 14 -------------- 1 file changed, 14 deletions(-) (limited to 'include') diff --git a/include/libcamera/base/utils.h b/include/libcamera/base/utils.h index ed88b716..eb7bcdf4 100644 --- a/include/libcamera/base/utils.h +++ b/include/libcamera/base/utils.h @@ -367,20 +367,6 @@ decltype(auto) abs_diff(const T &a, const T &b) return a - b; } -namespace details { - -struct defopt_t { - template - operator T() const - { - return T{}; - } -}; - -} /* namespace details */ - -constexpr details::defopt_t defopt; - } /* namespace utils */ #ifndef __DOXYGEN__ -- cgit v1.2.1