From 92d9df69243000082559084a6fba2929cc18cc83 Mon Sep 17 00:00:00 2001 From: Laurent Pinchart Date: Sun, 27 Jan 2019 15:39:26 +0100 Subject: libcamera: camera: Fix operator= definition The class assignment operator is usually defined as returning a reference to the object, to allow a = b = c statements. While the return type makes no difference when deleting the operator in a class definition, it's still a good practice to use the correct return type. Fix it in the Camera and CameraManager classes. Signed-off-by: Laurent Pinchart --- include/libcamera/camera.h | 2 +- include/libcamera/camera_manager.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'include') diff --git a/include/libcamera/camera.h b/include/libcamera/camera.h index a2ded62d..5ad8a09f 100644 --- a/include/libcamera/camera.h +++ b/include/libcamera/camera.h @@ -23,7 +23,7 @@ public: const std::string &name); Camera(const Camera &) = delete; - void operator=(const Camera &) = delete; + Camera &operator=(const Camera &) = delete; const std::string &name() const; diff --git a/include/libcamera/camera_manager.h b/include/libcamera/camera_manager.h index 56dbd26f..cf3a85ae 100644 --- a/include/libcamera/camera_manager.h +++ b/include/libcamera/camera_manager.h @@ -38,7 +38,7 @@ public: private: CameraManager(); CameraManager(const CameraManager &) = delete; - void operator=(const CameraManager &) = delete; + CameraManager &operator=(const CameraManager &) = delete; ~CameraManager(); std::unique_ptr enumerator_; -- cgit v1.2.1