From f2a1817275db8fb77acb5f2771b7577be8642194 Mon Sep 17 00:00:00 2001 From: Laurent Pinchart Date: Thu, 18 Nov 2021 14:48:17 +0200 Subject: Documentation: coding-style: Document the git commit hooks checkstyle.py is ignored too often. Document how to automate its usage through git commit hooks. Signed-off-by: Laurent Pinchart Reviewed-by: Umang Jain Reviewed-by: Kieran Bingham --- Documentation/coding-style.rst | 8 ++++++++ 1 file changed, 8 insertions(+) (limited to 'Documentation') diff --git a/Documentation/coding-style.rst b/Documentation/coding-style.rst index 4e8d6988..053fdd99 100644 --- a/Documentation/coding-style.rst +++ b/Documentation/coding-style.rst @@ -418,4 +418,12 @@ diff that fixes the issues, on top of the corresponding commit. As the script is in early development false positive are expected. The flagged issues should be reviewed, but the diff doesn't need to be applied blindly. +Execution of checkstyle.py can be automated through git commit hooks. Example +of pre-commit and post-commit hooks are available in `utils/hooks/pre-commit` +and `utils/hooks/post-commit`. You can install either hook by copying it to +`.git/hooks/`. The post-commit hook is easier to start with as it will only flag +potential issues after committing, while the pre-commit hook will abort the +commit if issues are detected and requires usage of `git commit --no-verify` to +ignore false positives. + Happy hacking, libcamera awaits your patches! -- cgit v1.2.1