From dac1a0549a27b72993e22f273ae05050a13c69a8 Mon Sep 17 00:00:00 2001 From: Laurent Pinchart Date: Mon, 24 Oct 2022 13:43:47 +0300 Subject: apps: cam: Fix compilation error with clang when libtiff-4 is not found When libtiff-4 is not found, the private camera_ member of the FileSink class is set but never used. This causes a compilation error with clang: In file included from ../../src/apps/cam/file_sink.cpp:19: ../../src/apps/cam/file_sink.h:39:27: error: private field 'camera_' is not used [-Werror,-Wunused-private-field] const libcamera::Camera *camera_; Fix by making the camera_ member field conditional on HAVE_TIFF. Fixes: 6404b163bcbb ("cam: file_sink: Add support for DNG output") Signed-off-by: Laurent Pinchart Acked-by: Kieran Bingham --- src/apps/cam/file_sink.cpp | 8 ++++++-- src/apps/cam/file_sink.h | 2 ++ 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src/apps/cam/file_sink.cpp b/src/apps/cam/file_sink.cpp index 9d60c04e..4dfacc10 100644 --- a/src/apps/cam/file_sink.cpp +++ b/src/apps/cam/file_sink.cpp @@ -21,10 +21,14 @@ using namespace libcamera; -FileSink::FileSink(const libcamera::Camera *camera, +FileSink::FileSink([[maybe_unused]] const libcamera::Camera *camera, const std::map &streamNames, const std::string &pattern) - : camera_(camera), streamNames_(streamNames), pattern_(pattern) + : +#ifdef HAVE_TIFF + camera_(camera), +#endif + streamNames_(streamNames), pattern_(pattern) { } diff --git a/src/apps/cam/file_sink.h b/src/apps/cam/file_sink.h index 9ce8b619..300edf8d 100644 --- a/src/apps/cam/file_sink.h +++ b/src/apps/cam/file_sink.h @@ -36,7 +36,9 @@ private: libcamera::FrameBuffer *buffer, const libcamera::ControlList &metadata); +#ifdef HAVE_TIFF const libcamera::Camera *camera_; +#endif std::map streamNames_; std::string pattern_; std::map> mappedBuffers_; -- cgit v1.2.1