From bb6167873ee309da12ed71c7943d54823e4b6709 Mon Sep 17 00:00:00 2001 From: Naushir Patuck Date: Tue, 6 Oct 2020 10:07:31 +0100 Subject: pipeline: ipa: raspberrypi: Switch to use C++17 features where possible With the recent change to use C++17, the following code changes can be made: - Use C++17 [[fallthough]] attribute instead of /* Fall through */. - Swap boost::any to std::any. Signed-off-by: Naushir Patuck Reviewed-by: Kieran Bingham Reviewed-by: Laurent Pinchart Signed-off-by: Laurent Pinchart --- src/ipa/raspberrypi/controller/metadata.hpp | 9 ++++----- src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 2 +- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/src/ipa/raspberrypi/controller/metadata.hpp b/src/ipa/raspberrypi/controller/metadata.hpp index f3a8dfab..4f44ffc6 100644 --- a/src/ipa/raspberrypi/controller/metadata.hpp +++ b/src/ipa/raspberrypi/controller/metadata.hpp @@ -8,13 +8,12 @@ // A simple class for carrying arbitrary metadata, for example about an image. +#include #include #include #include #include -#include - namespace RPiController { class Metadata @@ -31,7 +30,7 @@ public: auto it = data_.find(tag); if (it == data_.end()) return -1; - value = boost::any_cast(it->second); + value = std::any_cast(it->second); return 0; } void Clear() @@ -53,7 +52,7 @@ public: auto it = data_.find(tag); if (it == data_.end()) return nullptr; - return boost::any_cast(&it->second); + return std::any_cast(&it->second); } template void SetLocked(std::string const &tag, T const &value) @@ -69,7 +68,7 @@ public: private: mutable std::mutex mutex_; - std::map data_; + std::map data_; }; typedef std::shared_ptr MetadataPtr; diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp index 1052bdce..26dbd257 100644 --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp @@ -1494,7 +1494,7 @@ void RPiCameraData::handleState() * No break here, we want to try running the pipeline again. * The fallthrough clause below suppresses compiler warnings. */ - /* Fall through */ + [[fallthrough]]; case State::Idle: tryRunPipeline(); -- cgit v1.2.1