From a8de1f398ddc26a655756e8954fd4d90dff3b3fa Mon Sep 17 00:00:00 2001 From: Laurent Pinchart Date: Mon, 17 Jun 2024 15:13:09 +0300 Subject: ipa: rkisp1: agc: Rename frame context update variable to updateMetering The frame context agc.update variable is used to indicate if the ISP histogram metering parameters need to be updated. Rename it to updateMetering to make usage more explicit. Suggested-by: Paul Elder Signed-off-by: Laurent Pinchart Reviewed-by: Kieran Bingham --- src/ipa/rkisp1/algorithms/agc.cpp | 4 ++-- src/ipa/rkisp1/ipa_context.cpp | 4 ++-- src/ipa/rkisp1/ipa_context.h | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp index 965030b6..f12f8b60 100644 --- a/src/ipa/rkisp1/algorithms/agc.cpp +++ b/src/ipa/rkisp1/algorithms/agc.cpp @@ -250,7 +250,7 @@ void Agc::queueRequest(IPAContext &context, const auto &meteringMode = controls.get(controls::AeMeteringMode); if (meteringMode) { - frameContext.agc.update = agc.meteringMode != *meteringMode; + frameContext.agc.updateMetering = agc.meteringMode != *meteringMode; agc.meteringMode = static_cast(*meteringMode); } @@ -288,7 +288,7 @@ void Agc::prepare(IPAContext &context, const uint32_t frame, frameContext.agc.gain = context.activeState.agc.automatic.gain; } - if (frame > 0 && !frameContext.agc.update) + if (frame > 0 && !frameContext.agc.updateMetering) return; /* Configure the measurement window. */ diff --git a/src/ipa/rkisp1/ipa_context.cpp b/src/ipa/rkisp1/ipa_context.cpp index ab6cfae1..9f3f576a 100644 --- a/src/ipa/rkisp1/ipa_context.cpp +++ b/src/ipa/rkisp1/ipa_context.cpp @@ -317,8 +317,8 @@ namespace libcamera::ipa::rkisp1 { * \var IPAFrameContext::agc.maxFrameDuration * \brief Maximum frame duration as set by the FrameDurationLimits control * - * \var IPAFrameContext::agc.update - * \brief Indicate if new ISP parameters need to be applied + * \var IPAFrameContext::agc.updateMetering + * \brief Indicate if new ISP AGC metering parameters need to be applied */ /** diff --git a/src/ipa/rkisp1/ipa_context.h b/src/ipa/rkisp1/ipa_context.h index 79775905..8602b408 100644 --- a/src/ipa/rkisp1/ipa_context.h +++ b/src/ipa/rkisp1/ipa_context.h @@ -123,7 +123,7 @@ struct IPAFrameContext : public FrameContext { controls::AeExposureModeEnum exposureMode; controls::AeMeteringModeEnum meteringMode; utils::Duration maxFrameDuration; - bool update; + bool updateMetering; } agc; struct { -- cgit v1.2.1