From 8af95d6854889dc66746429ccf8888e3a81f6baf Mon Sep 17 00:00:00 2001 From: Laurent Pinchart Date: Sun, 4 Aug 2024 14:50:35 +0300 Subject: utils: checkstyle.py: Warn when no valid Signed-off-by line is found All commits to libcamera must include a Signed-off-by line, and that rule is enforced through git hooks and CI. This however doesn't prevent patches from being submitted without an SoB tag, as noticed multiple times in the past. Extend the checkstyle.py trailer checker to issue a warning when the SoB line is missing to try and improve the situation. Signed-off-by: Laurent Pinchart Reviewed-by: Milan Zamazal Reviewed-by: Kieran Bingham --- utils/checkstyle.py | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/utils/checkstyle.py b/utils/checkstyle.py index 4185c39a..7d480bdf 100755 --- a/utils/checkstyle.py +++ b/utils/checkstyle.py @@ -493,6 +493,8 @@ class TrailersChecker(CommitChecker): def check(cls, commit, top_level): issues = [] + sob_found = False + for trailer in commit.trailers: match = TrailersChecker.trailer_regex.fullmatch(trailer) if not match: @@ -515,6 +517,12 @@ class TrailersChecker(CommitChecker): issues.append(CommitIssue(f"Malformed value '{value}' for commit trailer '{key}'")) continue + if key == 'Signed-off-by': + sob_found = True + + if not sob_found: + issues.append(CommitIssue(f"No valid 'Signed-off-by' trailer found, see Documentation/contributing.rst")) + return issues -- cgit v1.2.1