From 4a5ad4e9b04e0c41efddc9800d4462c23c016904 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Barnab=C3=A1s=20P=C5=91cze?= Date: Mon, 24 Feb 2025 10:38:00 +0100 Subject: libcamera: media_object: Fix unnecessary copy MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit `MediaEntity::ancillaryEntities()` can just return a const lvalue reference to the underlying array, a copy need not be made. That was likely the original intention. Fixes: 9490c664b57a6c ("libcamera: Add members to MediaEntity to support ancillary entities") Signed-off-by: Barnabás Pőcze Reviewed-by: Daniel Scally Reviewed-by: Laurent Pinchart --- include/libcamera/internal/media_object.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/libcamera/internal/media_object.h b/include/libcamera/internal/media_object.h index 9356d204..54e2e5ce 100644 --- a/include/libcamera/internal/media_object.h +++ b/include/libcamera/internal/media_object.h @@ -112,7 +112,7 @@ public: unsigned int deviceMinor() const { return minor_; } const std::vector &pads() const { return pads_; } - const std::vector ancillaryEntities() const { return ancillaryEntities_; } + const std::vector &ancillaryEntities() const { return ancillaryEntities_; } const MediaPad *getPadByIndex(unsigned int index) const; const MediaPad *getPadById(unsigned int id) const; -- cgit v1.2.1