From 496e4467d298ef17fc1254f0e4e999ffc36a9b37 Mon Sep 17 00:00:00 2001 From: Laurent Pinchart Date: Tue, 28 Sep 2021 00:09:37 +0300 Subject: libcamera: control_serializer: Fix usage of uninitialized variable MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The idMap variable may be used uninitialized in the ControlSerializer::deserialize() function as reported by gcc 11: ../../src/libcamera/control_serializer.cpp: In member function ‘T libcamera::ControlSerializer::deserialize(libcamera::ByteStreamBuffer&) [with T = libcamera::ControlList]’: ../../src/libcamera/control_serializer.cpp:609:33: error: ‘idMap’ may be used uninitialized in this function [-Werror=maybe-uninitialized] 609 | ControlList ctrls(*idMap); | This is due to a missing default case in a switch/case. Fix it by adding the default case. Fixes: 6b1404fc4836 ("libcamera: control_serializer: Fix usage of uninitialized variable") Signed-off-by: Laurent Pinchart Reviewed-by: Jacopo Mondi --- src/libcamera/control_serializer.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libcamera/control_serializer.cpp b/src/libcamera/control_serializer.cpp index 77b77448..e87d2362 100644 --- a/src/libcamera/control_serializer.cpp +++ b/src/libcamera/control_serializer.cpp @@ -594,6 +594,7 @@ ControlList ControlSerializer::deserialize(ByteStreamBuffer &buffer break; case IPA_CONTROL_ID_MAP_V4L2: + default: LOG(Serializer, Fatal) << "A list of V4L2 controls requires an ControlInfoMap"; return {}; -- cgit v1.2.1