From 330ea9d946f97001593f65a08276c44076fb0f10 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?N=C3=ADcolas=20F=2E=20R=2E=20A=2E=20Prado?= Date: Tue, 6 Apr 2021 15:23:33 -0300 Subject: libcamera: pipeline: rkisp1: Stop IPA before streams MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The IPA should be stopped before stopping the streams in order to avoid a "No BufferCache available to queue" issue. This issue happened while running lc-compliance. Suggested-by: Kieran Bingham Signed-off-by: Nícolas F. R. A. Prado Reviewed-by: Niklas Söderlund Reviewed-by: Kieran Bingham Signed-off-by: Niklas Söderlund --- src/libcamera/pipeline/rkisp1/rkisp1.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp index 03757327..c122c9be 100644 --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp @@ -827,6 +827,8 @@ void PipelineHandlerRkISP1::stop(Camera *camera) isp_->setFrameStartEnabled(false); + data->ipa_->stop(); + selfPath_.stop(); mainPath_.stop(); @@ -840,8 +842,6 @@ void PipelineHandlerRkISP1::stop(Camera *camera) LOG(RkISP1, Warning) << "Failed to stop parameters for " << camera->id(); - data->ipa_->stop(); - data->frameInfo_.clear(); freeBuffers(camera); -- cgit v1.2.1