libcamera: ipu3: Do not re-queue cancelled buffers
When a video device is stopped all the buffers there queued are released
and their state is set to BufferCancelled.
Currently, on buffer completion, cancelled buffers are blindly re-queued
to the ImgU input or CIO2 output devices, preventing them to be
re-started succesfully in future capture sessions.
Fix that by inspecting the buffers status and skip re-queueing if
they're reported as cancelled. For the ImgU output buffer this is not
required, as cancelled request should be reported to applications in
order to report them failure of the capture operations.
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
0 files changed, 0 insertions, 0 deletions
17'>117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
/* SPDX-License-Identifier: LGPL-2.1-or-later */
/*
* Copyright (C) 2019, Google Inc.
*
* rkisp1.cpp - RkISP1 Image Processing Algorithms
*/
#include <algorithm>
#include <math.h>
#include <queue>
#include <stdint.h>
#include <string.h>
#include <linux/rkisp1-config.h>
#include <ipa/ipa_interface.h>
#include <ipa/ipa_module_info.h>
#include <ipa/rkisp1.h>
#include <libcamera/buffer.h>
#include <libcamera/control_ids.h>
#include <libcamera/request.h>
#include "log.h"
#include "utils.h"
namespace libcamera {
LOG_DEFINE_CATEGORY(IPARkISP1)
class IPARkISP1 : public IPAInterface
{
public:
int init() override { return 0; }
void configure(const std::map<unsigned int, IPAStream> &streamConfig,
const std::map<unsigned int, ControlInfoMap> &entityControls) override;
void mapBuffers(const std::vector<IPABuffer> &buffers) override;
void unmapBuffers(const std::vector<unsigned int> &ids) override;
void processEvent(const IPAOperationData &event) override;
private:
void queueRequest(unsigned int frame, rkisp1_isp_params_cfg *params,
const ControlList &controls);
void updateStatistics(unsigned int frame,
const rkisp1_stat_buffer *stats);
void setControls(unsigned int frame);
void metadataReady(unsigned int frame, unsigned int aeState);
std::map<unsigned int, BufferMemory> bufferInfo_;
ControlInfoMap ctrls_;
/* Camera sensor controls. */
bool autoExposure_;
uint32_t exposure_;
uint32_t minExposure_;
uint32_t maxExposure_;
uint32_t gain_;
uint32_t minGain_;
uint32_t maxGain_;
};
void IPARkISP1::configure(const std::map<unsigned int, IPAStream> &streamConfig,
const std::map<unsigned int, ControlInfoMap> &entityControls)
{
if (entityControls.empty())
return;
ctrls_ = entityControls.at(0);
const auto itExp = ctrls_.find(V4L2_CID_EXPOSURE);
if (itExp == ctrls_.end()) {
LOG(IPARkISP1, Error) << "Can't find exposure control";
return;
}
const auto itGain = ctrls_.find(V4L2_CID_ANALOGUE_GAIN);
if (itGain == ctrls_.end()) {
LOG(IPARkISP1, Error) << "Can't find gain control";
return;
}
autoExposure_ = true;
minExposure_ = std::max<uint32_t>(itExp->second.min().get<int32_t>(), 1);
maxExposure_ = itExp->second.max().get<int32_t>();
exposure_ = minExposure_;
minGain_ = std::max<uint32_t>(itGain->second.min().get<int32_t>(), 1);
maxGain_ = itGain->second.max().get<int32_t>();
gain_ = minGain_;
LOG(IPARkISP1, Info)
<< "Exposure: " << minExposure_ << "-" << maxExposure_
<< " Gain: " << minGain_ << "-" << maxGain_;
setControls(0);
}
void IPARkISP1::mapBuffers(const std::vector<IPABuffer> &buffers)
{
for (const IPABuffer &buffer : buffers) {
bufferInfo_[buffer.id] = buffer.memory;
bufferInfo_[buffer.id].planes()[0].mem();
}
}
void IPARkISP1::unmapBuffers(const std::vector<unsigned int> &ids)
{
for (unsigned int id : ids)
bufferInfo_.erase(id);
}
void IPARkISP1::processEvent(const IPAOperationData &event)
{
switch (event.operation) {
case RKISP1_IPA_EVENT_SIGNAL_STAT_BUFFER: {
unsigned int frame = event.data[0];
unsigned int bufferId = event.data[1];
const rkisp1_stat_buffer *stats =
static_cast<rkisp1_stat_buffer *>(bufferInfo_[bufferId].planes()[0].mem());
updateStatistics(frame, stats);
break;
}
case RKISP1_IPA_EVENT_QUEUE_REQUEST: {
unsigned int frame = event.data[0];
unsigned int bufferId = event.data[1];
rkisp1_isp_params_cfg *params =
static_cast<rkisp1_isp_params_cfg *>(bufferInfo_[bufferId].planes()[0].mem());
queueRequest(frame, params, event.controls[0]);
break;
}
default:
LOG(IPARkISP1, Error) << "Unkown event " << event.operation;
break;
}
}
void IPARkISP1::queueRequest(unsigned int frame, rkisp1_isp_params_cfg *params,
const ControlList &controls)
{
/* Prepare parameters buffer. */
memset(params, 0, sizeof(*params));
/* Auto Exposure on/off. */
if (controls.contains(controls::AeEnable)) {
autoExposure_ = controls.get(controls::AeEnable);
if (autoExposure_)
params->module_ens = CIFISP_MODULE_AEC;
params->module_en_update = CIFISP_MODULE_AEC;
}
IPAOperationData op;
op.operation = RKISP1_IPA_ACTION_PARAM_FILLED;
queueFrameAction.emit(frame, op);
}
void IPARkISP1::updateStatistics(unsigned int frame,
const rkisp1_stat_buffer *stats)
{
const cifisp_stat *params = &stats->params;
unsigned int aeState = 0;
if (stats->meas_type & CIFISP_STAT_AUTOEXP) {
const cifisp_ae_stat *ae = ¶ms->ae;
const unsigned int target = 60;
unsigned int value = 0;
unsigned int num = 0;
for (int i = 0; i < CIFISP_AE_MEAN_MAX; i++) {
if (ae->exp_mean[i] <= 15)
continue;
value += ae->exp_mean[i];
num++;
}
value /= num;
double factor = (double)target / value;
if (frame % 3 == 0) {
double exposure;
exposure = factor * exposure_ * gain_ / minGain_;
exposure_ = utils::clamp<uint64_t>((uint64_t)exposure,
minExposure_,
maxExposure_);
exposure = exposure / exposure_ * minGain_;
gain_ = utils::clamp<uint64_t>((uint64_t)exposure,
minGain_, maxGain_);
setControls(frame + 1);
}
aeState = fabs(factor - 1.0f) < 0.05f ? 2 : 1;
}
metadataReady(frame, aeState);
}
void IPARkISP1::setControls(unsigned int frame)
{
IPAOperationData op;
op.operation = RKISP1_IPA_ACTION_V4L2_SET;
ControlList ctrls(ctrls_);
ctrls.set(V4L2_CID_EXPOSURE, static_cast<int32_t>(exposure_));
ctrls.set(V4L2_CID_ANALOGUE_GAIN, static_cast<int32_t>(gain_));
op.controls.push_back(ctrls);
queueFrameAction.emit(frame, op);
}
void IPARkISP1::metadataReady(unsigned int frame, unsigned int aeState)
{
ControlList ctrls(controls::controls);
if (aeState)
ctrls.set(controls::AeLocked, aeState == 2);
IPAOperationData op;
op.operation = RKISP1_IPA_ACTION_METADATA;
op.controls.push_back(ctrls);
queueFrameAction.emit(frame, op);
}
/*
* External IPA module interface
*/
extern "C" {
const struct IPAModuleInfo ipaModuleInfo = {
IPA_MODULE_API_VERSION,
1,
"PipelineHandlerRkISP1",
"RkISP1 IPA",
"LGPL-2.1-or-later",
};
IPAInterface *ipaCreate()
{
return new IPARkISP1();
}
}
} /* namespace libcamera */
