libcamera/libcamera.git - libcamera official repository

diff options

author	Niklas Söderlund <niklas.soderlund@ragnatech.se>	2019-09-26 12:45:08 +0200
committer	Niklas Söderlund <niklas.soderlund@ragnatech.se>	2019-09-27 21:30:37 +0200
commit	b13b134616613060505d776d2fef1446b139ec0f (patch)
tree	3d90049b288c14ab38e9d1ea59ff95016d30eb9b /test/log/log_process.cpp
parent	f0b2582c4961ce9e5b637a2a326aa59ebc905e52 (diff)

qcam: Fix unregister of not registered timer

If an unregistered timer is given to QtEventDispatcher::unregisterTimer() an error is printed and Qt gets confused and locks up. Fix this by following the libcamera documentation that passing a unregistered timer is a no-op. Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Diffstat (limited to 'test/log/log_process.cpp')

0 files changed, 0 insertions, 0 deletions

/* SPDX-License-Identifier: LGPL-2.1-or-later */ /* * Copyright (C) 2019, Google Inc. * * v4l2_device.cpp - Common base for V4L2 video devices and subdevices */ #include "v4l2_device.h" #include <fcntl.h> #include <iomanip> #include <string.h> #include <sys/ioctl.h> #include <sys/syscall.h> #include <unistd.h> #include "log.h" #include "utils.h" #include "v4l2_controls.h" /** * \file v4l2_device.h * \brief Common base for V4L2 devices and subdevices */ namespace libcamera { LOG_DEFINE_CATEGORY(V4L2) /** * \class V4L2Device * \brief Base class for V4L2VideoDevice and V4L2Subdevice * * The V4L2Device class groups together the methods and fields common to * both the V4L2VideoDevice and V4L2Subdevice classes, and provides a base * class with methods to open and close the device node associated with the * device and to perform IOCTL system calls on it. * * The V4L2Device class cannot be instantiated directly, as its constructor * is protected. Users should instead create instances of one the derived * classes to model either a V4L2 video device or a V4L2 subdevice. */ /** * \brief Construct a V4L2Device * \param[in] deviceNode The device node filesystem path * * Initialize the file descriptor to -1 and store the \a deviceNode to be used * at open() time, and the \a logTag to prefix log messages with. */ V4L2Device::V4L2Device(const std::string &deviceNode) : deviceNode_(deviceNode), fd_(-1) { } /** * \brief Destroy a V4L2Device */ V4L2Device::~V4L2Device() { } /** * \brief Open a V4L2 device node * \param[in] flags Access mode flags * * Open the device node path with the provided access mode \a flags and * initialize the file descriptor, which was initially set to -1. * * \return 0 on success or a negative error code otherwise */ int V4L2Device::open(unsigned int flags) { if (isOpen()) { LOG(V4L2, Error) << "Device already open"; return -EBUSY; } int ret = syscall(SYS_openat, AT_FDCWD, deviceNode_.c_str(), flags); if (ret < 0) { ret = -errno; LOG(V4L2, Error) << "Failed to open V4L2 device: " << strerror(-ret); return ret; } fd_ = ret; listControls(); return 0; } /** * \brief Set the file descriptor of a V4L2 device * \param[in] fd The file descriptor handle * * This method allows a device to provide an already opened file descriptor * referring to the V4L2 device node, instead of opening it with open(). This * can be used for V4L2 M2M devices where a single video device node is used for * both the output and capture devices, or when receiving an open file * descriptor in a context that doesn't have permission to open the device node * itself. * * This method and the open() method are mutually exclusive, only one of the two * shall be used for a V4L2Device instance. * * \return 0 on success or a negative error code otherwise */ int V4L2Device::setFd(int fd) { if (isOpen()) return -EBUSY; fd_ = fd; return 0; } /** * \brief Close the device node * * Reset the file descriptor to -1 */ void V4L2Device::close() { if (!isOpen()) return; if (::close(fd_) < 0) LOG(V4L2, Error) << "Failed to close V4L2 device: " << strerror(errno); fd_ = -1; } /** * \fn V4L2Device::isOpen() * \brief Check if the V4L2 device node is open * \return True if the V4L2 device node is open, false otherwise */ /** * \fn V4L2Device::controls() * \brief Retrieve the supported V4L2 controls and their information * \return A map of the V4L2 controls supported by the device */ /** * \brief Read controls from the device * \param[inout] ctrls The list of controls to read * * This method reads the value of all controls contained in \a ctrls, and stores * their values in the corresponding \a ctrls entry. * * If any control in \a ctrls is not supported by the device, is disabled (i.e. * has the V4L2_CTRL_FLAG_DISABLED flag set), is a compound control, or if any * other error occurs during validation of the requested controls, no control is * read and this method returns -EINVAL. * * If an error occurs while reading the controls, the index of the first control * that couldn't be read is returned. The value of all controls below that index * are updated in \a ctrls, while the value of all the other controls are not * changed. * * \return 0 on success or an error code otherwise * \retval -EINVAL One of the control is not supported or not accessible * \retval i The index of the control that failed */ int V4L2Device::getControls(ControlList *ctrls) { unsigned int count = ctrls->size(); if (count == 0) return 0; struct v4l2_ext_control v4l2Ctrls[count]; memset(v4l2Ctrls, 0, sizeof(v4l2Ctrls)); unsigned int i = 0; for (const auto &ctrl : *ctrls) { unsigned int id = ctrl.first; const auto iter = controls_.find(id); if (iter == controls_.end()) { LOG(V4L2, Error) << "Control " << utils::hex(id) << " not found"; return -EINVAL; } v4l2Ctrls[i].id = id; i++; } struct v4l2_ext_controls v4l2ExtCtrls = {}; v4l2ExtCtrls.which = V4L2_CTRL_WHICH_CUR_VAL; v4l2ExtCtrls.controls = v4l2Ctrls; v4l2ExtCtrls.count = count; int ret = ioctl(VIDIOC_G_EXT_CTRLS, &v4l2ExtCtrls); if (ret) { unsigned int errorIdx = v4l2ExtCtrls.error_idx; /* Generic validation error. */ if (errorIdx == 0 || errorIdx >= count) { LOG(V4L2, Error) << "Unable to read controls: " << strerror(ret); return -EINVAL; } /* A specific control failed. */ LOG(V4L2, Error) << "Unable to read control " << errorIdx << ": " << strerror(ret); count = errorIdx - 1; ret = errorIdx; } updateControls(ctrls, v4l2Ctrls, count); return ret; } /** * \brief Write controls to the device * \param[in] ctrls The list of controls to write * * This method writes the value of all controls contained in \a ctrls, and * stores the values actually applied to the device in the corresponding * \a ctrls entry. * * If any control in \a ctrls is not supported by the device, is disabled (i.e. * has the V4L2_CTRL_FLAG_DISABLED flag set), is read-only, is a * compound control, or if any other error occurs during validation of * the requested controls, no control is written and this method returns * -EINVAL. * * If an error occurs while writing the controls, the index of the first * control that couldn't be written is returned. All controls below that index


context:
space:
mode: