summaryrefslogtreecommitdiff
path: root/test/camera/configuration_default.cpp
diff options
context:
space:
mode:
authorVedant Paranjape <vedantparanjape160201@gmail.com>2021-06-02 19:41:38 +0530
committerPaul Elder <paul.elder@ideasonboard.com>2021-06-07 14:06:50 +0900
commit1e5cee701781276fb03f18e704a5a6ea8f24eff8 (patch)
tree49a0459ff186b3d54f4ba25d34a0ed33b722eb68 /test/camera/configuration_default.cpp
parentabdb11d9ccad4cf0f566b826d7068e67d5800388 (diff)
gstreamer: Add error checking in gst_libcamera_src_task_enter()
The return value from generateConfiguration() was not checked. Only assert was added as a guard which checked if the size of the generated camera config was equal to size of roles passed to it. If the roles variable has an invalid/unsupported role, it will return a nullptr and then trying to access a member on a nullptr for size comparison will result in a segmentation fault. So, if the function returns a nullptr, simply push an error message on GstBus and gracefully exit. Signed-off-by: Vedant Paranjape <vedantparanjape160201@gmail.com> Reviewed-by: Paul Elder <paul.elder@ideasonboard.com> Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com> Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>
Diffstat (limited to 'test/camera/configuration_default.cpp')
0 files changed, 0 insertions, 0 deletions