summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorNicholas Roth <nicholas@rothemail.net>2022-10-27 22:17:22 -0500
committerKieran Bingham <kieran.bingham@ideasonboard.com>2022-10-28 11:56:25 +0100
commite1e6c1b2f6680342c6a243b5a0007f593cd7e793 (patch)
tree2a02589ce14198098301d554616e9b594adbd184 /src
parent6a2f971035c2df711b10200f9c8c011d9a420e58 (diff)
ipa: raspberry: replace abs() with std::abs()
pwl.cpp uses abs() instead of std::abs(), which causes unexpected behavior in the Clang compiler used for Android. Replace with C++-standard absolute value function std::abs(), which supports double-precision absolute values in a standard way. Signed-off-by: Nicholas Roth <nicholas@rothemail.net> Reviewed-by: Jacopo Mondi <jacopo@jmondi.org> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> Reviewed-by: Naushir Patuck <naush@raspberrypi.com> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Diffstat (limited to 'src')
-rw-r--r--src/ipa/raspberrypi/controller/pwl.cpp5
1 files changed, 3 insertions, 2 deletions
diff --git a/src/ipa/raspberrypi/controller/pwl.cpp b/src/ipa/raspberrypi/controller/pwl.cpp
index c59f5fa1..70c2e24b 100644
--- a/src/ipa/raspberrypi/controller/pwl.cpp
+++ b/src/ipa/raspberrypi/controller/pwl.cpp
@@ -6,6 +6,7 @@
*/
#include <cassert>
+#include <cmath>
#include <stdexcept>
#include "pwl.h"
@@ -168,7 +169,7 @@ Pwl Pwl::compose(Pwl const &other, const double eps) const
while (thisSpan != (int)points_.size() - 1) {
double dx = points_[thisSpan + 1].x - points_[thisSpan].x,
dy = points_[thisSpan + 1].y - points_[thisSpan].y;
- if (abs(dy) > eps &&
+ if (std::abs(dy) > eps &&
otherSpan + 1 < (int)other.points_.size() &&
points_[thisSpan + 1].y >=
other.points_[otherSpan + 1].x + eps) {
@@ -181,7 +182,7 @@ Pwl Pwl::compose(Pwl const &other, const double eps) const
points_[thisSpan].y) *
dx / dy;
thisY = other.points_[++otherSpan].x;
- } else if (abs(dy) > eps && otherSpan > 0 &&
+ } else if (std::abs(dy) > eps && otherSpan > 0 &&
points_[thisSpan + 1].y <=
other.points_[otherSpan - 1].x - eps) {
/*