summaryrefslogtreecommitdiff
path: root/src/v4l2/v4l2_camera.h
diff options
context:
space:
mode:
authorNaushir Patuck <naush@raspberrypi.com>2024-06-06 12:52:23 +0100
committerKieran Bingham <kieran.bingham@ideasonboard.com>2024-06-13 09:32:59 +0100
commit634bc7838f879c208df1915b2259e2a7f8dcefd7 (patch)
tree538d77f63ce0d599b2114ed0f23a8699048e65f3 /src/v4l2/v4l2_camera.h
parent20b8538a197c45597eecf5c7a51058263e816eb9 (diff)
pipeline: rpi: Don't validate configuration in generateConfiguration()
generateConfiguration() called validate() as a final step, causing the stride and frameSize fields in StreamConfiguration to be filled in based on the pixel format and width/height. If a user application did not clear the stride field when setting up a custom pixel format and width/height, the pipeline handler would respect this stride and possibly overallocate buffers with a larger stride than needed. Fix this by removing the call to validate() completely, leaving the stride and frameSize fields defaulting to 0. Removal of this call is inconsequential as we hard-code a valid configuration for Raspberry Pi platforms in generateConfiguration(). Bug: https://github.com/raspberrypi/libcamera/issues/138 Bug: https://github.com/raspberrypi/libcamera/issues/141 Signed-off-by: Naushir Patuck <naush@raspberrypi.com> Reviewed-by: David Plowman <david.plowman@raspberrypi.com> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Diffstat (limited to 'src/v4l2/v4l2_camera.h')
0 files changed, 0 insertions, 0 deletions