diff options
author | Laurent Pinchart <laurent.pinchart@ideasonboard.com> | 2022-08-07 20:39:19 +0300 |
---|---|---|
committer | Laurent Pinchart <laurent.pinchart@ideasonboard.com> | 2022-08-09 02:31:10 +0300 |
commit | 96a5c699700492750183c925339a69da7e2c2326 (patch) | |
tree | f3e4f73257aff719062717dee77a402d5c00f93a /src/qcam/assets/feathericons/settings.svg | |
parent | 9165b5973cb57507718e959e597a36277978e688 (diff) |
cam: kms_sink: Make lifetime management of DRM request safer
The drmRequest is KMSSink::processRequest() is created as a naked
pointer, passed to the constructor of the KMSSink::Request object that
stores it in a std::unique_ptr<>, and used later in the function. The
current implementation is safe, but could be prone to both memory leaks
and use-after-free bugs if modified. Improve it by replacing the naked
pointer with a std::unique_ptr<>.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Reviewed-by: Eric Curtin <ecurtin@redhat.com>
Tested-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Diffstat (limited to 'src/qcam/assets/feathericons/settings.svg')
0 files changed, 0 insertions, 0 deletions