diff options
author | Laurent Pinchart <laurent.pinchart@ideasonboard.com> | 2022-09-30 04:08:47 +0300 |
---|---|---|
committer | Laurent Pinchart <laurent.pinchart@ideasonboard.com> | 2022-10-01 00:01:56 +0300 |
commit | 79f0fc937d95cbf1bd39f04dfd8b83206bda5098 (patch) | |
tree | d964865780525e85a6286504cb9bf2662fe93afa /src/ipa/rkisp1/algorithms/lsc.cpp | |
parent | c97cf467ea79ed886dc549bff6837900427ca11e (diff) |
ipa: rkisp1: Remove initialized_ flags from algorithms
Multiple algorithms have an initialized_ flag that they set to true at
the end of the init() function, and check at the beginning of prepare()
to skip preparation. This serves no real purpose, as the flag can only
be false if init() fails, in which case the IPA module initialization as
a whole will fail.
Drop the initialized_ flags.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Diffstat (limited to 'src/ipa/rkisp1/algorithms/lsc.cpp')
-rw-r--r-- | src/ipa/rkisp1/algorithms/lsc.cpp | 8 |
1 files changed, 1 insertions, 7 deletions
diff --git a/src/ipa/rkisp1/algorithms/lsc.cpp b/src/ipa/rkisp1/algorithms/lsc.cpp index 44245caa..102535bd 100644 --- a/src/ipa/rkisp1/algorithms/lsc.cpp +++ b/src/ipa/rkisp1/algorithms/lsc.cpp @@ -89,7 +89,6 @@ static std::vector<uint16_t> parseTable(const YamlObject &tuningData, } LensShadingCorrection::LensShadingCorrection() - : initialized_(false) { } @@ -114,8 +113,6 @@ int LensShadingCorrection::init([[maybe_unused]] IPAContext &context, gbData_.empty() || bData_.empty()) return -EINVAL; - initialized_ = true; - return 0; } @@ -125,7 +122,7 @@ int LensShadingCorrection::init([[maybe_unused]] IPAContext &context, int LensShadingCorrection::configure(IPAContext &context, [[maybe_unused]] const IPACameraSensorInfo &configInfo) { - context.configuration.lsc.enabled = initialized_; + context.configuration.lsc.enabled = true; return 0; } @@ -139,9 +136,6 @@ void LensShadingCorrection::prepare(IPAContext &context, const uint32_t frame, if (frame > 0) return; - if (!initialized_) - return; - struct rkisp1_cif_isp_lsc_config &config = params->others.lsc_config; const Size &size = context.configuration.sensor.size; Size totalSize{}; |