diff options
author | Laurent Pinchart <laurent.pinchart@ideasonboard.com> | 2022-09-30 04:08:47 +0300 |
---|---|---|
committer | Laurent Pinchart <laurent.pinchart@ideasonboard.com> | 2022-10-01 00:01:56 +0300 |
commit | 79f0fc937d95cbf1bd39f04dfd8b83206bda5098 (patch) | |
tree | d964865780525e85a6286504cb9bf2662fe93afa /src/ipa/rkisp1/algorithms/dpcc.cpp | |
parent | c97cf467ea79ed886dc549bff6837900427ca11e (diff) |
ipa: rkisp1: Remove initialized_ flags from algorithms
Multiple algorithms have an initialized_ flag that they set to true at
the end of the init() function, and check at the beginning of prepare()
to skip preparation. This serves no real purpose, as the flag can only
be false if init() fails, in which case the IPA module initialization as
a whole will fail.
Drop the initialized_ flags.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Diffstat (limited to 'src/ipa/rkisp1/algorithms/dpcc.cpp')
-rw-r--r-- | src/ipa/rkisp1/algorithms/dpcc.cpp | 7 |
1 files changed, 1 insertions, 6 deletions
diff --git a/src/ipa/rkisp1/algorithms/dpcc.cpp b/src/ipa/rkisp1/algorithms/dpcc.cpp index d2a015d0..80a1b734 100644 --- a/src/ipa/rkisp1/algorithms/dpcc.cpp +++ b/src/ipa/rkisp1/algorithms/dpcc.cpp @@ -37,7 +37,7 @@ namespace ipa::rkisp1::algorithms { LOG_DEFINE_CATEGORY(RkISP1Dpcc) DefectPixelClusterCorrection::DefectPixelClusterCorrection() - : initialized_(false), config_({}) + : config_({}) { } @@ -223,8 +223,6 @@ int DefectPixelClusterCorrection::init([[maybe_unused]] IPAContext &context, } } - initialized_ = true; - return 0; } @@ -239,9 +237,6 @@ void DefectPixelClusterCorrection::prepare([[maybe_unused]] IPAContext &context, if (frame > 0) return; - if (!initialized_) - return; - params->others.dpcc_config = config_; params->module_en_update |= RKISP1_CIF_ISP_MODULE_DPCC; |