summaryrefslogtreecommitdiff
path: root/src/ipa/ipu3/algorithms/agc.h
diff options
context:
space:
mode:
authorLaurent Pinchart <laurent.pinchart@ideasonboard.com>2021-10-15 03:28:20 +0300
committerLaurent Pinchart <laurent.pinchart@ideasonboard.com>2021-10-19 13:14:54 +0300
commit3b07397f0e7d93d54535d9c87e7b9c19d04c97f0 (patch)
tree59bcf3ee79c0f2d8d58a0aa8e9d48aa2fa4ee364 /src/ipa/ipu3/algorithms/agc.h
parent5ae92dae5882f5450c647b4af95ef37ba0fded72 (diff)
ipa: ipu3: agc: Remove "using" directive from agc.h header
"using" directives are harmful in headers, as they propagate the namespace short-circuit to all files that include the header, directly or indirectly. Drop the directive from agc.h, and use utils::Duration explicitly. While at it, shorten the namespace qualifier from libcamera::utils:: to utils:: in agc.cpp for Duration. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>
Diffstat (limited to 'src/ipa/ipu3/algorithms/agc.h')
-rw-r--r--src/ipa/ipu3/algorithms/agc.h14
1 files changed, 6 insertions, 8 deletions
diff --git a/src/ipa/ipu3/algorithms/agc.h b/src/ipa/ipu3/algorithms/agc.h
index 64b71c65..e0c315fc 100644
--- a/src/ipa/ipu3/algorithms/agc.h
+++ b/src/ipa/ipu3/algorithms/agc.h
@@ -21,8 +21,6 @@ struct IPACameraSensorInfo;
namespace ipa::ipu3::algorithms {
-using utils::Duration;
-
class Agc : public Algorithm
{
public:
@@ -43,13 +41,13 @@ private:
double iqMean_;
- Duration lineDuration_;
- Duration maxExposureTime_;
+ utils::Duration lineDuration_;
+ utils::Duration maxExposureTime_;
- Duration prevExposure_;
- Duration prevExposureNoDg_;
- Duration currentExposure_;
- Duration currentExposureNoDg_;
+ utils::Duration prevExposure_;
+ utils::Duration prevExposureNoDg_;
+ utils::Duration currentExposure_;
+ utils::Duration currentExposureNoDg_;
uint32_t stride_;
};