diff options
author | Laurent Pinchart <laurent.pinchart@ideasonboard.com> | 2022-07-20 14:47:33 +0300 |
---|---|---|
committer | Laurent Pinchart <laurent.pinchart@ideasonboard.com> | 2022-07-28 14:14:00 +0300 |
commit | f6d6181d3c91efa526b5027319331db9ac75f65b (patch) | |
tree | 080170ea014d5ceb58428f8e573ca6db0d6d599c /src/cam/sdl_texture_yuyv.cpp | |
parent | dc1f4a91dfefa9f86202ab148e05fb901b6e3e73 (diff) |
cam: sdl_sink: Pass a Span<const uint8_t> to SDLTexture::update()
The SDLTexture::update() function isn't meant to modify the data it
receives. Make the Span type const to ensure this at compile time. While
at it, pass the Span by value instead of reference, as a Span is only a
pointer and size, which will fit in registers and will avoid pointer
dereferences in the callee.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
Diffstat (limited to 'src/cam/sdl_texture_yuyv.cpp')
-rw-r--r-- | src/cam/sdl_texture_yuyv.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/cam/sdl_texture_yuyv.cpp b/src/cam/sdl_texture_yuyv.cpp index cc161b2c..637c0900 100644 --- a/src/cam/sdl_texture_yuyv.cpp +++ b/src/cam/sdl_texture_yuyv.cpp @@ -14,7 +14,7 @@ SDLTextureYUYV::SDLTextureYUYV(const SDL_Rect &rect) { } -void SDLTextureYUYV::update(const Span<uint8_t> &data) +void SDLTextureYUYV::update(Span<const uint8_t> data) { SDL_UpdateTexture(ptr_, &rect_, data.data(), pitch_); } |