cam: sdl_sink: Pass a Span<const uint8_t> to SDLTexture::update()

The SDLTexture::update() function isn't meant to modify the data it
receives. Make the Span type const to ensure this at compile time. While
at it, pass the Span by value instead of reference, as a Span is only a
pointer and size, which will fit in registers and will avoid pointer
dereferences in the callee.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>

1 files changed, 2 insertions, 2 deletions

diff --git a/src/cam/sdl_texture_mjpg.h b/src/cam/sdl_texture_mjpg.h
index 328c45a9..5141ed73 100644
--- a/src/cam/sdl_texture_mjpg.h
+++ b/src/cam/sdl_texture_mjpg.h
@@ -14,10 +14,10 @@ class SDLTextureMJPG : public SDLTexture
 public:
 	SDLTextureMJPG(const SDL_Rect &rect);
 
-	void update(const libcamera::Span<uint8_t> &data) override;
+	void update(libcamera::Span<const uint8_t> data) override;
 
 private:
-	int decompress(const libcamera::Span<uint8_t> &data);
+	int decompress(libcamera::Span<const uint8_t> data);
 
 	std::unique_ptr<unsigned char[]> rgb_;
 };