diff options
author | Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> | 2022-08-29 11:44:45 +0300 |
---|---|---|
committer | Laurent Pinchart <laurent.pinchart@ideasonboard.com> | 2022-10-20 02:42:07 +0300 |
commit | ab2a10f00757a3defbf027591a696d06a45c835c (patch) | |
tree | d6c31ca2f8761499d22295272582c0f02edf4c60 /src/apps/qcam/assets/feathericons/check-square.svg | |
parent | 662df4ca26cfe9603a2824d31131324c30c8b6bd (diff) |
libcamera: base: log: Fix LogCategory creation issues
Each declaration of a LogCategory will create a new LogCategory, and
will be stored in an unordered_set Logger::categories_. This means that
when a plugin .so is unloaded and loaded, as happens when destructing
and creating a CamereManager, we'll get duplicate categories.
The Logger::registerCategory docs say "Log categories must have unique
names. If a category with the same name already exists this function
performs no operation.". The code does not comply with this.
We solve the issue with two changes:
Change the unordered_set to a vector for simplicity, as there's no need
for an unordered_set.
Instead of using the LogCategory constructor to create new categories in
_LOG_CATEGORY() macro, use a factory method. The factory method will
return either an existing LogCategory if one exists with the given name,
or a newly created one.
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Diffstat (limited to 'src/apps/qcam/assets/feathericons/check-square.svg')
0 files changed, 0 insertions, 0 deletions