libcamera/libcamera.git - libcamera official repository

diff options

author	Milan Zamazal <mzamazal@redhat.com>	2024-09-27 15:46:09 +0200
committer	Kieran Bingham <kieran.bingham@ideasonboard.com>	2024-09-27 15:01:57 +0100
commit	cca55c83f5ed22cbcc03506d847f99b162e34d81 (patch)
tree	c8ef9f28aba20059bcd828bcc02e285533a06f92 /src/android/camera_hal_manager.h
parent	306b0f952fa4191df92770d2b754d594f1cfb0cb (diff)

libcamera: software_isp: Define skeletons for IPA refactoring

Software ISP image processing algorithms are currently defined in a simplified way, different from other libcamera pipelines. This is not good for several reasons: - It makes the software ISP code harder to understand due to its different structuring. - Adding more algorithms may make the code harder to understand generally. - Mass libcamera code changes may not be easily applicable to software ISP. - Algorithm sharing with other pipelines is not easily possible. This patch introduces basic software ISP IPA skeletons structured similarly to the other pipelines. The newly added files are currently not used or compiled and the general skeleton structures don't contain anything particular. It is just a preparation step for a larger refactoring and the code will be actually used and extended as needed in followup patches. Signed-off-by: Milan Zamazal <mzamazal@redhat.com> Reviewed-by: Umang Jain <umang.jain@ideasonboard.com> Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

Diffstat (limited to 'src/android/camera_hal_manager.h')

0 files changed, 0 insertions, 0 deletions

/* SPDX-License-Identifier: GPL-2.0-or-later */ /* * Copyright (C) 2019, Google Inc. * * libcamera V4L2 M2M video device tests */ #include <iostream> #include <libcamera/buffer.h> #include <libcamera/event_dispatcher.h> #include <libcamera/timer.h> #include "device_enumerator.h" #include "media_device.h" #include "thread.h" #include "v4l2_videodevice.h" #include "test.h" using namespace std; using namespace libcamera; class V4L2M2MDeviceTest : public Test { public: V4L2M2MDeviceTest() : vim2m_(nullptr), outputFrames_(0), captureFrames_(0) { } void outputBufferComplete(Buffer *buffer) { cout << "Received output buffer " << buffer->index() << endl; outputFrames_++; /* Requeue the buffer for further use. */ vim2m_->output()->queueBuffer(buffer); } void receiveCaptureBuffer(Buffer *buffer) { cout << "Received capture buffer " << buffer->index() << endl; captureFrames_++; /* Requeue the buffer for further use. */ vim2m_->capture()->queueBuffer(buffer); } protected: int init() { enumerator_ = DeviceEnumerator::create(); if (!enumerator_) { cerr << "Failed to create device enumerator" << endl; return TestFail; } if (enumerator_->enumerate()) { cerr << "Failed to enumerate media devices" << endl; return TestFail; } DeviceMatch dm("vim2m"); dm.add("vim2m-source"); dm.add("vim2m-sink"); media_ = enumerator_->search(dm); if (!media_) { cerr << "No vim2m device found" << endl; return TestSkip; } return TestPass; } int run() { constexpr unsigned int bufferCount = 4; EventDispatcher *dispatcher = Thread::current()->eventDispatcher(); int ret; MediaEntity *entity = media_->getEntityByName("vim2m-source"); vim2m_ = new V4L2M2MDevice(entity->deviceNode()); if (vim2m_->open()) { cerr << "Failed to open VIM2M device" << endl; return TestFail; } V4L2VideoDevice *capture = vim2m_->capture(); V4L2VideoDevice *output = vim2m_->output(); V4L2DeviceFormat format = {}; if (capture->getFormat(&format)) { cerr << "Failed to get capture format" << endl; return TestFail; } format.size.width = 640; format.size.height = 480; if (capture->setFormat(&format)) { cerr << "Failed to set capture format" << endl; return TestFail; } if (output->setFormat(&format)) { cerr << "Failed to set output format" << endl; return TestFail; } capturePool_.createBuffers(bufferCount); outputPool_.createBuffers(bufferCount); ret = capture->exportBuffers(&capturePool_); if (ret) { cerr << "Failed to export Capture Buffers" << endl; return TestFail; } ret = output->exportBuffers(&outputPool_); if (ret) { cerr << "Failed to export Output Buffers" << endl; return TestFail; } capture->bufferReady.connect(this, &V4L2M2MDeviceTest::receiveCaptureBuffer); output->bufferReady.connect(this, &V4L2M2MDeviceTest::outputBufferComplete); std::vector<std::unique_ptr<Buffer>> captureBuffers; captureBuffers = capture->queueAllBuffers(); if (captureBuffers.empty()) { cerr << "Failed to queue all Capture Buffers" << endl; return TestFail; } /* We can't "queueAllBuffers()" on an output device, so we do it manually */ std::vector<std::unique_ptr<Buffer>> outputBuffers; for (unsigned int i = 0; i < outputPool_.count(); ++i) { Buffer *buffer = new Buffer(i); outputBuffers.emplace_back(buffer); ret = output->queueBuffer(buffer); if (ret) { cerr << "Failed to queue output buffer" << i << endl; return TestFail; } } ret = capture->streamOn(); if (ret) { cerr << "Failed to streamOn capture" << endl; return TestFail; } ret = output->streamOn(); if (ret) { cerr << "Failed to streamOn output" << endl; return TestFail; } Timer timeout; timeout.start(5000); while (timeout.isRunning()) { dispatcher->processEvents(); if (captureFrames_ > 30) break; } cerr << "Output " << outputFrames_ << " frames" << std::endl; cerr << "Captured " << captureFrames_ << " frames" << std::endl; if (captureFrames_ < 30) { cerr << "Failed to capture 30 frames within timeout." << std::endl; return TestFail; } ret = capture->streamOff(); if (ret) { cerr << "Failed to StreamOff the capture device." << std::endl; return TestFail; } ret = output->streamOff(); if (ret) { cerr << "Failed to StreamOff the output device." << std::endl; return TestFail; } return TestPass; } void cleanup() { delete vim2m_; }; private: std::unique_ptr<DeviceEnumerator> enumerator_; std::shared_ptr<MediaDevice> media_; V4L2M2MDevice *vim2m_; BufferPool capturePool_; BufferPool outputPool_; unsigned int outputFrames_; unsigned int captureFrames_; }; TEST_REGISTER(V4L2M2MDeviceTest);


context:
space:
mode: