diff options
| author | Vedant Paranjape <vedantparanjape160201@gmail.com> | 2021-09-21 23:09:55 +0530 |
|---|---|---|
| committer | Paul Elder <paul.elder@ideasonboard.com> | 2021-09-23 16:03:15 +0900 |
| commit | c7daf645d449fc74415770b9d811ec21571e7823 (patch) | |
| tree | f8a2961e6ded3a142b22cb7e7e5a0567ed10fb29 /src/android/camera_hal_manager.cpp | |
| parent | fa9a9d7f6b6452bf8d0fdd5de03512547b84204a (diff) | |
test: gstreamer: Simplify elements' ownerships
In gstreamer, when elements are created, usually a floating [1]
reference is returned which simply means, there is no ownership
transfer (yet). Once can simply check for NULL and return through
an error path, without bothering to clean up. Hence, g_autoptr is
not much of help here.
If the NULL checks have been passed successfully, elements are ready
to use. However, we must claim ownership/reference it before using
them via g_object_ref_sink().
This patch build upon this principle and removes the g_autoptr
from gstreamer test base class (gstreamer_test.cpp) whereever
necessary to tide up the code.
[1] https://gstreamer.freedesktop.org/documentation/additional/design/MT-refcounting.html?gi-language=c#refcounting1
Signed-off-by: Vedant Paranjape <vedantparanjape160201@gmail.com>
Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>
Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>
Diffstat (limited to 'src/android/camera_hal_manager.cpp')
0 files changed, 0 insertions, 0 deletions