diff options
author | Laurent Pinchart <laurent.pinchart@ideasonboard.com> | 2021-09-23 14:49:46 +0300 |
---|---|---|
committer | Laurent Pinchart <laurent.pinchart@ideasonboard.com> | 2021-09-24 13:25:33 +0300 |
commit | d4e15331cb593c1a681a79940805c008af5bcb18 (patch) | |
tree | b49d482f17903add431d37a417409eefeced0f40 | |
parent | d1713de60ab5c37c5b2de63fd75cb5b5e59248c5 (diff) |
libcamera: v4l2_videodevice: Don't move planes to construct FrameBuffer
The FrameBuffer class has no constructor that takes an rvalue reference
to planes. The std::move() is thus misleading as a copy will still take
place. Drop it to clarify the code, no functional change is introduced.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>
Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>
-rw-r--r-- | src/libcamera/v4l2_videodevice.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp index 9b3ee887..ba5f88cd 100644 --- a/src/libcamera/v4l2_videodevice.cpp +++ b/src/libcamera/v4l2_videodevice.cpp @@ -1376,7 +1376,7 @@ std::unique_ptr<FrameBuffer> V4L2VideoDevice::createBuffer(unsigned int index) } } - return std::make_unique<FrameBuffer>(std::move(planes)); + return std::make_unique<FrameBuffer>(planes); } FileDescriptor V4L2VideoDevice::exportDmabufFd(unsigned int index, |