summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKieran Bingham <kieran.bingham@ideasonboard.com>2023-07-11 09:56:47 +0100
committerKieran Bingham <kieran.bingham@ideasonboard.com>2023-07-18 09:26:24 +0100
commite2f0ad27b18b1502f59268bda2eeff4a7a21055c (patch)
tree100b21652cbe7c6cc0c7112124974f0232c6d5db
parent37106ba02a699eb485edcc2e5058dcaf25ee92a0 (diff)
utils: checkstyle.py: Derive Amendment from Commit
The Amendment commit class is derived from the StagedChanges class (which in turn derives from the Commit base class), however there is no code sharing between Amendment and StagedChanges other than the call to initalise through the base Commit class. Refactor the inheritance to make an Amendment derive directly from Commit. Reviewed-by: Umang Jain <umang.jain@ideasonboard.com> Tested-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
-rwxr-xr-xutils/checkstyle.py4
1 files changed, 2 insertions, 2 deletions
diff --git a/utils/checkstyle.py b/utils/checkstyle.py
index 2ba3165b..5663af81 100755
--- a/utils/checkstyle.py
+++ b/utils/checkstyle.py
@@ -269,9 +269,9 @@ class StagedChanges(Commit):
return parse_diff(diff.splitlines(True))
-class Amendment(StagedChanges):
+class Amendment(Commit):
def __init__(self):
- StagedChanges.__init__(self)
+ Commit.__init__(self, '')
def _parse(self):
# Create a title using HEAD commit