summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLaurent Pinchart <laurent.pinchart@ideasonboard.com>2024-06-24 22:24:41 +0300
committerLaurent Pinchart <laurent.pinchart@ideasonboard.com>2024-06-25 10:54:16 +0300
commit38c75f863a50c5d5e9b715f4edcc00ccc9aa37f4 (patch)
tree34e83954517f88bfc4e03d937eff64c0bb38e95f
parent4d0834ea0adfb5139e0ab83751d3e89d72e0a931 (diff)
libcamera: base: log: Declare log categories when defining them
libcamera will enable -Wmissing-declarations to catch mismatches between function declarations and definitions. There is one offender in log.h: when a category is defined with LOG_DEFINE_CATEGORY(), it generates a function with no declaration. Fix it by declaring the function using LOG_DECLARE_CATEGORY() as the first step of the category definition. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
-rw-r--r--include/libcamera/base/log.h1
1 files changed, 1 insertions, 0 deletions
diff --git a/include/libcamera/base/log.h b/include/libcamera/base/log.h
index b5775e49..df27df03 100644
--- a/include/libcamera/base/log.h
+++ b/include/libcamera/base/log.h
@@ -48,6 +48,7 @@ private:
extern const LogCategory &_LOG_CATEGORY(name)();
#define LOG_DEFINE_CATEGORY(name) \
+LOG_DECLARE_CATEGORY(name) \
const LogCategory &_LOG_CATEGORY(name)() \
{ \
/* The instance will be deleted by the Logger destructor. */ \