diff options
| author | Kieran Bingham <kieran.bingham@ideasonboard.com> | 2023-07-25 13:56:40 +0100 |
|---|---|---|
| committer | Kieran Bingham <kieran.bingham@ideasonboard.com> | 2023-10-16 16:38:08 +0100 |
| commit | c258302863da5fe36aba1caa82b27e9154b6c0a2 (patch) | |
| tree | ebad22ef8094948cd2af2ebfa1feb77990ff2044 | |
| parent | d05009d34c67dfb11e890eaee2858a7e99ed06e4 (diff) | |
py: gen-py-controls: Remove SceneFlicker workaround
The python bindings layer has to parse the libcamera controls to ensure
that they are converted to suitable names for the python layer.
Part of this strips out common prefixes from control names, however the
SceneFlicker control would end up using an illegal name if processed in
the same way as the other controls.
The SceneFlicker control has now been removed as part of the
introduction of the AeFlickerMode and AeFlickerPeriod controls.
Remove the workaround in the python layer.
Fixes: 6fdbf3f38c31 ("libcamera: controls: Add controls for AEC/AGC flicker avoidance")
Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Reviewed-by: David Plowman <david.plowman@raspberrypi.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
| -rwxr-xr-x | src/py/libcamera/gen-py-controls.py | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/src/py/libcamera/gen-py-controls.py b/src/py/libcamera/gen-py-controls.py index 99f3bbcf..9948c41e 100755 --- a/src/py/libcamera/gen-py-controls.py +++ b/src/py/libcamera/gen-py-controls.py @@ -48,9 +48,6 @@ def generate_py(controls, mode): # Adjustments for controls if name == 'LensShadingMapMode': prefix = 'LensShadingMapMode' - elif name == 'SceneFlicker': - # If we strip the prefix, we would get '50Hz', which is illegal name - prefix = '' else: prefix = find_common_prefix([e['name'] for e in enum]) else: |