summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMarvin Schmidt <marvin.schmidt1987@gmail.com>2022-08-29 20:58:49 +0200
committerLaurent Pinchart <laurent.pinchart@ideasonboard.com>2022-08-30 15:26:43 +0300
commit372621352de4b201568b03b51970b1f72e886fa6 (patch)
tree41f5b959d3da626ab2650fde755252fd412b2636
parent252561e77f3cfc2b2792a389a03f4f6722b09803 (diff)
ipa: rkisp1: Remove redundant call of std::string::c_str()
The constructor of libcamera::File takes a const reference to a std::string and clang-tidy's readability-redundant-string-cstr check warns about it: > ../src/ipa/rkisp1/rkisp1.cpp:147:12: warning: redundant call to 'c_str' [readability-redundant-string-cstr] > File file(settings.configurationFile.c_str()); > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > settings.configurationFile Signed-off-by: Marvin Schmidt <marvin.schmidt1987@gmail.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Umang Jain <umang.jain@ideasonboard.com> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
-rw-r--r--src/ipa/rkisp1/rkisp1.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp
index 27b4212b..9e3eb7fb 100644
--- a/src/ipa/rkisp1/rkisp1.cpp
+++ b/src/ipa/rkisp1/rkisp1.cpp
@@ -144,7 +144,7 @@ int IPARkISP1::init(const IPASettings &settings, unsigned int hwRevision,
}
/* Load the tuning data file. */
- File file(settings.configurationFile.c_str());
+ File file(settings.configurationFile);
if (!file.open(File::OpenModeFlag::ReadOnly)) {
int ret = file.error();
LOG(IPARkISP1, Error)