diff options
author | David Plowman <david.plowman@raspberrypi.com> | 2023-11-24 16:37:42 +0000 |
---|---|---|
committer | Kieran Bingham <kieran.bingham@ideasonboard.com> | 2023-11-30 15:44:58 +0000 |
commit | 8e215127c195b61a7cc787103b129a3af8e5ad2c (patch) | |
tree | c2ac29b2133e78a6b62b105e7f9746d1c6d76765 /.clang-tidy | |
parent | 2905eabad9ffa3a83c498d5a4a98a110fc0317af (diff) |
ipa: rpi: cac: Minor code improvements and tidying
We make a few small improvements to the code:
* The arrayToSet method is prevented from overwriting the end of the
array if there are too many values in the input table. If you supply
a table, it will force you to put the correct number of elements in
it.
* The arrayToSet and setStrength member functions are turned into
static functions. (There may be a different public setStrength
member function in future.)
* When no tables at all are given, the configuration is flagged as
being disabled, so that we can avoid copying tables full of zeroes
around. As a consequence, the pipeline handler too will disable this
hardware block rather than run it needlessly. (Note that the tuning
tool will put in a completely empty "rpi.cac" block if no CAC tuning
images are supplied, benefiting from this behaviour.)
* The initialise member function is removed as it does nothing.
Signed-off-by: David Plowman <david.plowman@raspberrypi.com>
Reviewed-by: Naushir Patuck <naush@raspberrypi.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Diffstat (limited to '.clang-tidy')
0 files changed, 0 insertions, 0 deletions