From c430d39d203488cf93ab4f12ff9eb8b3c6380212 Mon Sep 17 00:00:00 2001
From: Umang Jain <email@uajain.com>
Date: Fri, 23 Oct 2020 11:01:50 +0530
Subject: android: jpeg: encoder: Use pass-by-value for Exif parameter

Following the reasoning of pass-by-value for libcamera::Span
parameters from 90c193f2a700("android: Modify Encoder interface") i.e.
they are easy to copy/move/construct, align the Exif parameter passing
to the encoder interface in this consistent way.

Signed-off-by: Umang Jain <email@uajain.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 src/android/jpeg/encoder.h           | 2 +-
 src/android/jpeg/encoder_libjpeg.cpp | 2 +-
 src/android/jpeg/encoder_libjpeg.h   | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

(limited to 'src/android/jpeg')

diff --git a/src/android/jpeg/encoder.h b/src/android/jpeg/encoder.h
index 0ca2ba38..027233dc 100644
--- a/src/android/jpeg/encoder.h
+++ b/src/android/jpeg/encoder.h
@@ -19,7 +19,7 @@ public:
 	virtual int configure(const libcamera::StreamConfiguration &cfg) = 0;
 	virtual int encode(const libcamera::FrameBuffer &source,
 			   libcamera::Span<uint8_t> destination,
-			   const libcamera::Span<const uint8_t> &exifData) = 0;
+			   libcamera::Span<const uint8_t> exifData) = 0;
 };
 
 #endif /* __ANDROID_JPEG_ENCODER_H__ */
diff --git a/src/android/jpeg/encoder_libjpeg.cpp b/src/android/jpeg/encoder_libjpeg.cpp
index 4bea10cf..cfa53321 100644
--- a/src/android/jpeg/encoder_libjpeg.cpp
+++ b/src/android/jpeg/encoder_libjpeg.cpp
@@ -180,7 +180,7 @@ void EncoderLibJpeg::compressNV(const MappedBuffer *frame)
 }
 
 int EncoderLibJpeg::encode(const FrameBuffer &source, Span<uint8_t> dest,
-			   const Span<const uint8_t> &exifData)
+			   Span<const uint8_t> exifData)
 {
 	MappedFrameBuffer frame(&source, PROT_READ);
 	if (!frame.isValid()) {
diff --git a/src/android/jpeg/encoder_libjpeg.h b/src/android/jpeg/encoder_libjpeg.h
index 391a53ca..40505ddc 100644
--- a/src/android/jpeg/encoder_libjpeg.h
+++ b/src/android/jpeg/encoder_libjpeg.h
@@ -23,7 +23,7 @@ public:
 	int configure(const libcamera::StreamConfiguration &cfg) override;
 	int encode(const libcamera::FrameBuffer &source,
 		   libcamera::Span<uint8_t> destination,
-		   const libcamera::Span<const uint8_t> &exifData) override;
+		   libcamera::Span<const uint8_t> exifData) override;
 
 private:
 	void compressRGB(const libcamera::MappedBuffer *frame);
-- 
cgit v1.2.1