diff options
author | Laurent Pinchart <laurent.pinchart@ideasonboard.com> | 2020-03-01 17:56:59 +0200 |
---|---|---|
committer | Laurent Pinchart <laurent.pinchart@ideasonboard.com> | 2020-03-06 18:10:45 +0200 |
commit | 44ff5a18e42ad26a1621edf00f309c86304f13ac (patch) | |
tree | cd836cfc9980f2f211ba7aca78751727ac963c0b | |
parent | 7f2da874cdacf2870c7a55cd1bdf34a01b01787d (diff) |
libcamera: control_serializer: Use explicit ControlTypeNone case
Replace the default case with an explicit ControlTypeNone case in
ControlSerializer::load() to catch omissions when adding new control
types.
A return statement needs to be added to the end of the function to avoid
gcc incorrectly reporting that some exit paths don't contain a return
statement. The compiler will still warn that not all cases are handled
when adding a new control type.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
-rw-r--r-- | src/libcamera/control_serializer.cpp | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/src/libcamera/control_serializer.cpp b/src/libcamera/control_serializer.cpp index 6c676811..edf3e5ca 100644 --- a/src/libcamera/control_serializer.cpp +++ b/src/libcamera/control_serializer.cpp @@ -361,9 +361,11 @@ ControlValue ControlSerializer::load<ControlValue>(ControlType type, return ControlValue(value); } - default: + case ControlTypeNone: return ControlValue(); } + + return ControlValue(); } template<> |