diff options
author | Jacopo Mondi <jacopo@jmondi.org> | 2020-11-23 10:01:35 +0100 |
---|---|---|
committer | Jacopo Mondi <jacopo@jmondi.org> | 2020-11-30 11:51:10 +0100 |
commit | 20cf381c65df4c8cd45f00061f14f44e3780072e (patch) | |
tree | 4938a7a4d6be0bb0ef12e1b9f6c6694e6ef6d36f | |
parent | 743329b642d17b314421a8119a17300db3d796b2 (diff) |
libcamera: control_ids: Keep draft controls last
Let's try not to mix draft controls and regular controls.
Draft controls are unstable by definition, and removing or adding them
should not impact the enumeration of stable controls.
Keep draft controls at the end of the control_ids.yaml file and
add a comment to make clear where the draft controls section begins.
Acked-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
-rw-r--r-- | src/libcamera/control_ids.yaml | 28 |
1 files changed, 16 insertions, 12 deletions
diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml index c8874fa9..a883e27e 100644 --- a/src/libcamera/control_ids.yaml +++ b/src/libcamera/control_ids.yaml @@ -273,6 +273,22 @@ controls: size: [3x3] + - ScalerCrop: + type: Rectangle + description: | + Sets the image portion that will be scaled to form the whole of + the final output image. The (x,y) location of this rectangle is + relative to the PixelArrayActiveAreas that is being used. The units + remain native sensor pixels, even if the sensor is being used in + a binning or skipping mode. + + This control is only present when the pipeline supports scaling. Its + maximum valid value is given by the properties::ScalerCropMaximum + property, and the two can be used to implement digital zoom. + + # ---------------------------------------------------------------------------- + # Draft controls section + - AePrecaptureTrigger: type: int32_t draft: true @@ -518,16 +534,4 @@ controls: detection, additional format conversions etc) count as an additional pipeline stage. - - ScalerCrop: - type: Rectangle - description: | - Sets the image portion that will be scaled to form the whole of - the final output image. The (x,y) location of this rectangle is - relative to the PixelArrayActiveAreas that is being used. The units - remain native sensor pixels, even if the sensor is being used in - a binning or skipping mode. - - This control is only present when the pipeline supports scaling. Its - maximum valid value is given by the properties::ScalerCropMaximum - property, and the two can be used to implement digital zoom. ... |