libcamera/libcamera.git - libcamera official repository

diff options

author	Jacopo Mondi <jacopo@jmondi.org>	2021-04-21 17:20:00 +0200
committer	Jacopo Mondi <jacopo@jmondi.org>	2021-05-06 15:08:34 +0200
commit	f3481886255675a6ba1342865bf8fd0033a30eba (patch)
tree	8381156e6ad0098965c14a1a3685b5bf0213b96e /src/libcamera/pipeline/uvcvideo/uvcvideo.cpp
parent	a5c881645a855d26b0b1fd7746212aa9f6beddb4 (diff)

test: control_list: Check for Brightness presence

The current test verifies that after adding a new control to a list already populated with one control the new one is present. However the test wrongly tests for its presence twice instead of making sure the existing control is still there. Fix this by checking for the presence of both controls after the update, and fix the error message accordingly. Fixes: a8c40942b99e ("libcamera: controls: Improve the API towards applications") Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se> Reviewed-by: Hirokazu Honda <hiroh@chromium.org> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>

Diffstat (limited to 'src/libcamera/pipeline/uvcvideo/uvcvideo.cpp')

0 files changed, 0 insertions, 0 deletions

/* SPDX-License-Identifier: GPL-2.0-or-later */ /* * Copyright (C) 2020, Google Inc. * * object.cpp - Object deletion tests */ #include <iostream> #include <libcamera/object.h> #include "libcamera/internal/thread.h" #include "test.h" using namespace std; using namespace libcamera; class TestObject : public Object { public: TestObject(unsigned int *count) : deleteCount_(count) { } ~TestObject() { /* Count the deletions from the correct thread. */ if (thread() == Thread::current()) (*deleteCount_)++; } unsigned int *deleteCount_; }; class NewThread : public Thread { public: NewThread(Object *obj) : object_(obj) { } protected: void run() { object_->deleteLater(); } private: Object *object_; }; class ObjectDeleteTest : public Test { protected: int run() { /* * Test that deferred deletion is executed from the object's * thread, not the caller's thread. */ unsigned int count = 0; TestObject *obj = new TestObject(&count); NewThread thread(obj); thread.start(); thread.wait(); Thread::current()->dispatchMessages(Message::Type::DeferredDelete); if (count != 1) { cout << "Failed to dispatch DeferredDelete (" << count << ")" << endl; return TestFail; } /* * Test that multiple calls to deleteLater() delete the object * once only. */ count = 0; obj = new TestObject(&count); obj->deleteLater(); obj->deleteLater(); Thread::current()->dispatchMessages(Message::Type::DeferredDelete); if (count != 1) { cout << "Multiple deleteLater() failed (" << count << ")" << endl; return TestFail; } return TestPass; } }; TEST_REGISTER(ObjectDeleteTest)


context:
space:
mode: