From 03fcc154eb0599e02276c9f64fce46b643104e20 Mon Sep 17 00:00:00 2001 From: Kieran Bingham Date: Thu, 7 Feb 2019 20:56:08 +0000 Subject: libcamera: v4l2_device: Simplify exportBuffers() exportBuffers() can only operate on an existing BufferPool allocation. The pool identifies its size through its .count() method. Passing a count in to the exportBuffers() call is redundant and can be incorrect if the value is not the same as the BufferPool size. Simplify the function and remove the unnecessary argument, correcting all uses throughout the code base. While we're here, remove the createBuffers() helper from the V4L2DeviceTest which only served to obfuscate which pool the buffers were being allocated for. Reviewed-by: Laurent Pinchart Signed-off-by: Kieran Bingham --- test/v4l2_device/v4l2_device_test.h | 2 -- 1 file changed, 2 deletions(-) (limited to 'test/v4l2_device/v4l2_device_test.h') diff --git a/test/v4l2_device/v4l2_device_test.h b/test/v4l2_device/v4l2_device_test.h index f22f0bb5..43539655 100644 --- a/test/v4l2_device/v4l2_device_test.h +++ b/test/v4l2_device/v4l2_device_test.h @@ -24,8 +24,6 @@ class V4L2DeviceTest : public Test public: V4L2DeviceTest() : dev_(nullptr){}; - void createBuffers(unsigned int qty) { pool_.createBuffers(qty); } - protected: int init(); void cleanup(); -- cgit v1.2.1