From b167158395e9238de99c1b6e5dac4f7394341df5 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Niklas=20S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>
Date: Wed, 4 Mar 2020 23:54:08 +0100
Subject: libcamera: V4L2BufferCache: Check for hot hit first
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Check for a hot cache hit before updating which buffer is best to evict
in case no hot hit is found. This doesn't change the behaviour, but
follows a more logical flow.
Suggested-by: Jacopo Mondi <jacopo@jmondi.org>
Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
src/libcamera/v4l2_videodevice.cpp | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
(limited to 'src')
diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp
index 268de60b..c495de85 100644
--- a/src/libcamera/v4l2_videodevice.cpp
+++ b/src/libcamera/v4l2_videodevice.cpp
@@ -212,15 +212,15 @@ int V4L2BufferCache::get(const FrameBuffer &buffer)
if (!entry.free)
continue;
- if (use < 0)
- use = index;
-
/* Try to find a cache hit by comparing the planes. */
if (entry == buffer) {
hit = true;
use = index;
break;
}
+
+ if (use < 0)
+ use = index;
}
if (!hit)
--
cgit v1.2.1