From 785d7418619454c26631e5c1ac516abbc4f33f35 Mon Sep 17 00:00:00 2001
From: Kaaira Gupta <kgupta@es.iitr.ac.in>
Date: Mon, 27 Jul 2020 21:51:43 +0530
Subject: libcamera: stream_option: use format name to set cam/qcam format
Replace hex input for pixel formats with their format names, for input in
cam and qcam.
Hence, remove the todo.
Signed-off-by: Kaaira Gupta <kgupta@es.iitr.ac.in>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
---
src/cam/stream_options.cpp | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
(limited to 'src')
diff --git a/src/cam/stream_options.cpp b/src/cam/stream_options.cpp
index bd12c8fd..4168e5d2 100644
--- a/src/cam/stream_options.cpp
+++ b/src/cam/stream_options.cpp
@@ -19,7 +19,7 @@ StreamKeyValueParser::StreamKeyValueParser()
ArgumentRequired);
addOption("height", OptionInteger, "Height in pixels",
ArgumentRequired);
- addOption("pixelformat", OptionInteger, "Pixel format",
+ addOption("pixelformat", OptionString, "Pixel format name",
ArgumentRequired);
}
@@ -95,9 +95,8 @@ int StreamKeyValueParser::updateConfiguration(CameraConfiguration *config,
cfg.size.height = opts["height"];
}
- /* \todo Translate 4CC string to pixelformat with modifier. */
if (opts.isSet("pixelformat"))
- cfg.pixelFormat = PixelFormat(opts["pixelformat"]);
+ cfg.pixelFormat = PixelFormat::fromString(opts["pixelformat"].toString());
}
return 0;
--
cgit v1.2.1