From df36fb4abb37c216d1eaf60a1772047b5205d0b7 Mon Sep 17 00:00:00 2001 From: David Plowman Date: Fri, 7 May 2021 12:37:27 +0100 Subject: ipa: raspberrypi: Make sensor embedded data parser use Span class Improve MdParser::Parse() by taking a Span, pointing to const data that it should not change, as its input buffer. Signed-off-by: David Plowman Reviewed-by: Laurent Pinchart Signed-off-by: Laurent Pinchart --- src/ipa/raspberrypi/cam_helper_imx477.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'src/ipa/raspberrypi/cam_helper_imx477.cpp') diff --git a/src/ipa/raspberrypi/cam_helper_imx477.cpp b/src/ipa/raspberrypi/cam_helper_imx477.cpp index 73a5ca7d..a4a58c15 100644 --- a/src/ipa/raspberrypi/cam_helper_imx477.cpp +++ b/src/ipa/raspberrypi/cam_helper_imx477.cpp @@ -21,7 +21,7 @@ class MdParserImx477 : public MdParserSmia { public: MdParserImx477(); - Status Parse(void *data) override; + Status Parse(libcamera::Span buffer) override; Status GetExposureLines(unsigned int &lines) override; Status GetGainCode(unsigned int &gain_code) override; private: @@ -107,7 +107,7 @@ MdParserImx477::MdParserImx477() reg_offsets_[0] = reg_offsets_[1] = reg_offsets_[2] = reg_offsets_[3] = -1; } -MdParser::Status MdParserImx477::Parse(void *data) +MdParser::Status MdParserImx477::Parse(libcamera::Span buffer) { bool try_again = false; @@ -126,7 +126,7 @@ MdParser::Status MdParserImx477::Parse(void *data) GAINLO_REG }; reg_offsets_[0] = reg_offsets_[1] = reg_offsets_[2] = reg_offsets_[3] = -1; - int ret = static_cast(findRegs(static_cast(data), + int ret = static_cast(findRegs(buffer, regs, reg_offsets_, 4)); /* * > 0 means "worked partially but parse again next time", @@ -142,7 +142,7 @@ MdParser::Status MdParserImx477::Parse(void *data) if (reg_offsets_[i] == -1) continue; - reg_values_[i] = static_cast(data)[reg_offsets_[i]]; + reg_values_[i] = buffer[reg_offsets_[i]]; } /* Re-parse next time if we were unhappy in some way. */ -- cgit v1.2.1