From 726e9274ea95fa46352556d340c5793a8da51fcd Mon Sep 17 00:00:00 2001 From: Naushir Patuck Date: Wed, 3 May 2023 13:20:27 +0100 Subject: pipeline: ipa: raspberrypi: Refactor and move the Raspberry Pi code Split the Raspberry Pi pipeline handler and IPA source code into common and VC4/BCM2835 specific file structures. For the pipeline handler, the common code files now live in src/libcamera/pipeline/rpi/common/ and the VC4-specific files in src/libcamera/pipeline/rpi/vc4/. For the IPA, the common code files now live in src/ipa/rpi/{cam_helper,controller}/ and the vc4 specific files in src/ipa/rpi/vc4/. With this change, the camera tuning files are now installed under share/libcamera/ipa/rpi/vc4/. To build the pipeline and IPA, the meson configuration options have now changed from "raspberrypi" to "rpi/vc4": meson setup build -Dipas=rpi/vc4 -Dpipelines=rpi/vc4 Signed-off-by: Naushir Patuck Reviewed-by: Jacopo Mondi Reviewed-by: Laurent Pinchart Signed-off-by: Laurent Pinchart --- src/ipa/raspberrypi/cam_helper_imx219.cpp | 115 ------------------------------ 1 file changed, 115 deletions(-) delete mode 100644 src/ipa/raspberrypi/cam_helper_imx219.cpp (limited to 'src/ipa/raspberrypi/cam_helper_imx219.cpp') diff --git a/src/ipa/raspberrypi/cam_helper_imx219.cpp b/src/ipa/raspberrypi/cam_helper_imx219.cpp deleted file mode 100644 index c3337ed0..00000000 --- a/src/ipa/raspberrypi/cam_helper_imx219.cpp +++ /dev/null @@ -1,115 +0,0 @@ -/* SPDX-License-Identifier: BSD-2-Clause */ -/* - * Copyright (C) 2019, Raspberry Pi Ltd - * - * cam_helper_imx219.cpp - camera helper for imx219 sensor - */ - -#include -#include -#include -#include - -/* - * We have observed that the imx219 embedded data stream randomly returns junk - * register values. Do not rely on embedded data until this has been resolved. - */ -#define ENABLE_EMBEDDED_DATA 0 - -#include "cam_helper.h" -#if ENABLE_EMBEDDED_DATA -#include "md_parser.h" -#endif - -using namespace RPiController; - -/* - * We care about one gain register and a pair of exposure registers. Their I2C - * addresses from the Sony IMX219 datasheet: - */ -constexpr uint32_t gainReg = 0x157; -constexpr uint32_t expHiReg = 0x15a; -constexpr uint32_t expLoReg = 0x15b; -constexpr uint32_t frameLengthHiReg = 0x160; -constexpr uint32_t frameLengthLoReg = 0x161; -constexpr uint32_t lineLengthHiReg = 0x162; -constexpr uint32_t lineLengthLoReg = 0x163; -constexpr std::initializer_list registerList [[maybe_unused]] - = { expHiReg, expLoReg, gainReg, frameLengthHiReg, frameLengthLoReg, - lineLengthHiReg, lineLengthLoReg }; - -class CamHelperImx219 : public CamHelper -{ -public: - CamHelperImx219(); - uint32_t gainCode(double gain) const override; - double gain(uint32_t gainCode) const override; - unsigned int mistrustFramesModeSwitch() const override; - bool sensorEmbeddedDataPresent() const override; - -private: - /* - * Smallest difference between the frame length and integration time, - * in units of lines. - */ - static constexpr int frameIntegrationDiff = 4; - - void populateMetadata(const MdParser::RegisterMap ®isters, - Metadata &metadata) const override; -}; - -CamHelperImx219::CamHelperImx219() -#if ENABLE_EMBEDDED_DATA - : CamHelper(std::make_unique(registerList), frameIntegrationDiff) -#else - : CamHelper({}, frameIntegrationDiff) -#endif -{ -} - -uint32_t CamHelperImx219::gainCode(double gain) const -{ - return (uint32_t)(256 - 256 / gain); -} - -double CamHelperImx219::gain(uint32_t gainCode) const -{ - return 256.0 / (256 - gainCode); -} - -unsigned int CamHelperImx219::mistrustFramesModeSwitch() const -{ - /* - * For reasons unknown, we do occasionally get a bogus metadata frame - * at a mode switch (though not at start-up). Possibly warrants some - * investigation, though not a big deal. - */ - return 1; -} - -bool CamHelperImx219::sensorEmbeddedDataPresent() const -{ - return ENABLE_EMBEDDED_DATA; -} - -void CamHelperImx219::populateMetadata(const MdParser::RegisterMap ®isters, - Metadata &metadata) const -{ - DeviceStatus deviceStatus; - - deviceStatus.lineLength = lineLengthPckToDuration(registers.at(lineLengthHiReg) * 256 + - registers.at(lineLengthLoReg)); - deviceStatus.shutterSpeed = exposure(registers.at(expHiReg) * 256 + registers.at(expLoReg), - deviceStatus.lineLength); - deviceStatus.analogueGain = gain(registers.at(gainReg)); - deviceStatus.frameLength = registers.at(frameLengthHiReg) * 256 + registers.at(frameLengthLoReg); - - metadata.set("device.status", deviceStatus); -} - -static CamHelper *create() -{ - return new CamHelperImx219(); -} - -static RegisterCamHelper reg("imx219", &create); -- cgit v1.2.1