From 16266def40cda947aaa1a50009e89f639c26e7cf Mon Sep 17 00:00:00 2001 From: Jean-Michel Hautbois Date: Thu, 19 Aug 2021 14:51:56 +0200 Subject: ipa: ipu3: convert AGC to the new algorithm interface In preparation for using the AGC through the new algorithm interfaces, convert the existing code to use the new function types. Now that the process call is rewritten, re-enable the compiler flag to warn when a function declaration hides virtual functions from a base class (-Woverloaded-virtual). We never use converged_ so remove its declaration. The controls may not need to be updated at each call, but it should be decided on the context side and not by a specific call by using a lock status in the Agc structure for instance. As the params_ local variable is not useful anymore, remove it here too. Signed-off-by: Jean-Michel Hautbois Reviewed-by: Kieran Bingham Reviewed-by: Laurent Pinchart --- src/ipa/ipu3/ipu3_agc.h | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) (limited to 'src/ipa/ipu3/ipu3_agc.h') diff --git a/src/ipa/ipu3/ipu3_agc.h b/src/ipa/ipu3/ipu3_agc.h index 2d86127d..0e922664 100644 --- a/src/ipa/ipu3/ipu3_agc.h +++ b/src/ipa/ipu3/ipu3_agc.h @@ -29,10 +29,8 @@ public: IPU3Agc(); ~IPU3Agc() = default; - void initialise(struct ipu3_uapi_grid_config &bdsGrid, const IPACameraSensorInfo &sensorInfo); - void process(const ipu3_uapi_stats_3a *stats, uint32_t &exposure, double &gain); - bool converged() { return converged_; } - bool updateControls() { return updateControls_; } + int configure(IPAContext &context, const IPAConfigInfo &configInfo) override; + void process(IPAContext &context, const ipu3_uapi_stats_3a *stats) override; private: void processBrightness(const ipu3_uapi_stats_3a *stats); @@ -44,9 +42,6 @@ private: uint64_t frameCount_; uint64_t lastFrame_; - bool converged_; - bool updateControls_; - double iqMean_; Duration lineDuration_; -- cgit v1.2.1