From 4e79b2ef310c3a68e4e9af4ee9c5e99fc0c17109 Mon Sep 17 00:00:00 2001 From: Laurent Pinchart Date: Fri, 12 Jul 2019 13:51:12 +0300 Subject: libcamera: v4l2_videodevice: Signal buffer completion at streamoff time MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit When stopping the stream buffers have been queued, in which case their completion is never be notified to the user. This can lead to memory leaks. Fix it by notifying completion of all queued buffers with the status set to error. As a result the base PipelineHandler implementation can be simplified, as all requests complete as the result of stopping the stream. The stop() method that manually completes all queued requests isn't needed anymore. Signed-off-by: Laurent Pinchart Reviewed-by: Niklas Söderlund --- include/libcamera/request.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'include') diff --git a/include/libcamera/request.h b/include/libcamera/request.h index f69b4e7a..9edf1ced 100644 --- a/include/libcamera/request.h +++ b/include/libcamera/request.h @@ -51,7 +51,7 @@ private: friend class PipelineHandler; int prepare(); - void complete(Status status); + void complete(); bool completeBuffer(Buffer *buffer); @@ -62,6 +62,7 @@ private: const uint64_t cookie_; Status status_; + bool cancelled_; }; } /* namespace libcamera */ -- cgit v1.2.1