From e2f0ad27b18b1502f59268bda2eeff4a7a21055c Mon Sep 17 00:00:00 2001 From: Kieran Bingham Date: Tue, 11 Jul 2023 09:56:47 +0100 Subject: utils: checkstyle.py: Derive Amendment from Commit The Amendment commit class is derived from the StagedChanges class (which in turn derives from the Commit base class), however there is no code sharing between Amendment and StagedChanges other than the call to initalise through the base Commit class. Refactor the inheritance to make an Amendment derive directly from Commit. Reviewed-by: Umang Jain Tested-by: Jacopo Mondi Signed-off-by: Kieran Bingham --- utils/checkstyle.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/utils/checkstyle.py b/utils/checkstyle.py index 2ba3165b..5663af81 100755 --- a/utils/checkstyle.py +++ b/utils/checkstyle.py @@ -269,9 +269,9 @@ class StagedChanges(Commit): return parse_diff(diff.splitlines(True)) -class Amendment(StagedChanges): +class Amendment(Commit): def __init__(self): - StagedChanges.__init__(self) + Commit.__init__(self, '') def _parse(self): # Create a title using HEAD commit -- cgit v1.2.1