From 93506de63af7fa94c458c359101ac0f4b99e8fc6 Mon Sep 17 00:00:00 2001 From: Laurent Pinchart Date: Mon, 5 Aug 2024 20:38:34 +0300 Subject: utils: checkstyle.py: Validate SoB trailer against author The TrailersChecker enforces the presence of a Signed-off-by tag in the trailer, but doesn't verify that the tag matches the commit's author. Add that verification, as required by the libcamera contribution process. Signed-off-by: Laurent Pinchart Reviewed-by: Stefan Klug Reviewed-by: Kieran Bingham --- utils/checkstyle.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/utils/checkstyle.py b/utils/checkstyle.py index e8451846..560a2c1e 100755 --- a/utils/checkstyle.py +++ b/utils/checkstyle.py @@ -525,10 +525,11 @@ class TrailersChecker(CommitChecker): continue if key == 'Signed-off-by': - sob_found = True + if value == commit.author: + sob_found = True if not sob_found: - issues.append(CommitIssue(f"No valid 'Signed-off-by' trailer found, see Documentation/contributing.rst")) + issues.append(CommitIssue(f"No 'Signed-off-by' trailer matching author '{commit.author}', see Documentation/contributing.rst")) return issues -- cgit v1.2.1