summaryrefslogtreecommitdiff
path: root/utils/checkstyle.py
diff options
context:
space:
mode:
authorLaurent Pinchart <laurent.pinchart@ideasonboard.com>2024-08-05 20:38:34 +0300
committerLaurent Pinchart <laurent.pinchart@ideasonboard.com>2024-08-07 18:38:45 +0300
commit93506de63af7fa94c458c359101ac0f4b99e8fc6 (patch)
tree1c6846668bd4b6489e5b429248dd2e048db0dd41 /utils/checkstyle.py
parentfd130ef21b7e52d0442ccbb26825dea300a8a70e (diff)
utils: checkstyle.py: Validate SoB trailer against author
The TrailersChecker enforces the presence of a Signed-off-by tag in the trailer, but doesn't verify that the tag matches the commit's author. Add that verification, as required by the libcamera contribution process. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Stefan Klug <stefan.klug@ideasonboard.com> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Diffstat (limited to 'utils/checkstyle.py')
-rwxr-xr-xutils/checkstyle.py5
1 files changed, 3 insertions, 2 deletions
diff --git a/utils/checkstyle.py b/utils/checkstyle.py
index e8451846..560a2c1e 100755
--- a/utils/checkstyle.py
+++ b/utils/checkstyle.py
@@ -525,10 +525,11 @@ class TrailersChecker(CommitChecker):
continue
if key == 'Signed-off-by':
- sob_found = True
+ if value == commit.author:
+ sob_found = True
if not sob_found:
- issues.append(CommitIssue(f"No valid 'Signed-off-by' trailer found, see Documentation/contributing.rst"))
+ issues.append(CommitIssue(f"No 'Signed-off-by' trailer matching author '{commit.author}', see Documentation/contributing.rst"))
return issues