libcamera/jmondi/libcamera.git - Jacopo Mondi's clone of libcamera

diff options

author	Laurent Pinchart <laurent.pinchart@ideasonboard.com>	2022-08-10 02:06:50 +0300
committer	Laurent Pinchart <laurent.pinchart@ideasonboard.com>	2022-10-07 18:28:21 +0300
commit	4bf68fdbe1493e57118dad4e94c2a46c50a9c402 (patch)
tree	772d5dd76f21ac6be06998d7579ac24cf2de8589 /test/ipc/unixsocket_ipc.cpp
parent	f9c28992a9f591124db24b44d94b88ff4ca294f8 (diff)

ipa: raspberrypi: Remove unneeded Span casts

Commit 09c1b081baa2 ("libcamera: controls: Generate and use fixed-sized Span types") added explicit Span casts for fixed extent spans that were required due to the ControlList::set() function that takes an std::initializer_list not being able to infer a control size from template arguments. This has now been fixed, so the casts are not needed anymore. Drop them. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Jacopo Mondi <jacopo@jmondi.org> Reviewed-by: Christian Rauch <Rauch.Christian@gmx.de> Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>

Diffstat (limited to 'test/ipc/unixsocket_ipc.cpp')

0 files changed, 0 insertions, 0 deletions

/* SPDX-License-Identifier: LGPL-2.1-or-later */ /* * Copyright (C) 2019, Google Inc. * * v4l2_device.cpp - Common base for V4L2 video devices and subdevices */ #include "libcamera/internal/v4l2_device.h" #include <fcntl.h> #include <iomanip> #include <string.h> #include <sys/ioctl.h> #include <sys/syscall.h> #include <unistd.h> #include "libcamera/internal/log.h" #include "libcamera/internal/utils.h" #include "libcamera/internal/v4l2_controls.h" /** * \file v4l2_device.h * \brief Common base for V4L2 devices and subdevices */ namespace libcamera { LOG_DEFINE_CATEGORY(V4L2) /** * \class V4L2Device * \brief Base class for V4L2VideoDevice and V4L2Subdevice * * The V4L2Device class groups together the methods and fields common to * both the V4L2VideoDevice and V4L2Subdevice classes, and provides a base * class with methods to open and close the device node associated with the * device and to perform IOCTL system calls on it. * * The V4L2Device class cannot be instantiated directly, as its constructor * is protected. Users should instead create instances of one the derived * classes to model either a V4L2 video device or a V4L2 subdevice. */ /** * \brief Construct a V4L2Device * \param[in] deviceNode The device node filesystem path * * Initialize the file descriptor to -1 and store the \a deviceNode to be used * at open() time, and the \a logTag to prefix log messages with. */ V4L2Device::V4L2Device(const std::string &deviceNode) : deviceNode_(deviceNode), fd_(-1) { } /** * \brief Destroy a V4L2Device */ V4L2Device::~V4L2Device() { } /** * \brief Open a V4L2 device node * \param[in] flags Access mode flags * * Open the device node path with the provided access mode \a flags and * initialize the file descriptor, which was initially set to -1. * * \return 0 on success or a negative error code otherwise */ int V4L2Device::open(unsigned int flags) { if (isOpen()) { LOG(V4L2, Error) << "Device already open"; return -EBUSY; } int ret = syscall(SYS_openat, AT_FDCWD, deviceNode_.c_str(), flags); if (ret < 0) { ret = -errno; LOG(V4L2, Error) << "Failed to open V4L2 device: " << strerror(-ret); return ret; } fd_ = ret; listControls(); return 0; } /** * \brief Set the file descriptor of a V4L2 device * \param[in] fd The file descriptor handle * * This method allows a device to provide an already opened file descriptor * referring to the V4L2 device node, instead of opening it with open(). This * can be used for V4L2 M2M devices where a single video device node is used for * both the output and capture devices, or when receiving an open file * descriptor in a context that doesn't have permission to open the device node * itself. * * This method and the open() method are mutually exclusive, only one of the two * shall be used for a V4L2Device instance. * * \return 0 on success or a negative error code otherwise */ int V4L2Device::setFd(int fd) { if (isOpen()) return -EBUSY; fd_ = fd; return 0; } /** * \brief Close the device node * * Reset the file descriptor to -1 */ void V4L2Device::close() { if (!isOpen()) return; if (::close(fd_) < 0) LOG(V4L2, Error) << "Failed to close V4L2 device: " << strerror(errno); fd_ = -1; } /** * \fn V4L2Device::isOpen() * \brief Check if the V4L2 device node is open * \return True if the V4L2 device node is open, false otherwise */ /** * \fn V4L2Device::controls() * \brief Retrieve the supported V4L2 controls and their information * \return A map of the V4L2 controls supported by the device */ /** * \brief Read controls from the device * \param[in] ids The list of controls to read, specified by their ID * * This method reads the value of all controls contained in \a ids, and returns * their values as a ControlList. * * If any control in \a ids is not supported by the device, is disabled (i.e. * has the V4L2_CTRL_FLAG_DISABLED flag set), or if any other error occurs * during validation of the requested controls, no control is read and this * method returns an empty control list. * * \return The control values in a ControlList on success, or an empty list on * error */ ControlList V4L2Device::getControls(const std::vector<uint32_t> &ids) { unsigned int count = ids.size(); if (count == 0) return {}; ControlList ctrls{ controls_ }; /* * Start by filling the ControlList. This can't be combined with filling * v4l2Ctrls, as updateControls() relies on both containers having the * same order, and the control list is based on a map, which is not * sorted by insertion order. */ for (uint32_t id : ids) { const auto iter = controls_.find(id); if (iter == controls_.end()) { LOG(V4L2, Error) << "Control " << utils::hex(id) << " not found"; return {}; } ctrls.set(id, {}); } struct v4l2_ext_control v4l2Ctrls[count]; memset(v4l2Ctrls, 0, sizeof(v4l2Ctrls)); unsigned int i = 0; for (auto &ctrl : ctrls) { unsigned int id = ctrl.first; const struct v4l2_query_ext_ctrl &info = controlInfo_[id]; if (info.flags & V4L2_CTRL_FLAG_HAS_PAYLOAD) { ControlType type; switch (info.type) { case V4L2_CTRL_TYPE_U8: type = ControlTypeByte; break; default: LOG(V4L2, Error) << "Unsupported payload control type " << info.type; return {}; } ControlValue &value = ctrl.second; value.reserve(type, true, info.elems); Span<uint8_t> data = value.data(); v4l2Ctrls[i].p_u8 = data.data(); v4l2Ctrls[i].size = data.size(); } v4l2Ctrls[i].id = id; i++; } struct v4l2_ext_controls v4l2ExtCtrls = {}; v4l2ExtCtrls.which = V4L2_CTRL_WHICH_CUR_VAL; v4l2ExtCtrls.controls = v4l2Ctrls; v4l2ExtCtrls.count = count; int ret = ioctl(VIDIOC_G_EXT_CTRLS, &v4l2ExtCtrls); if (ret) { unsigned int errorIdx = v4l2ExtCtrls.error_idx; /* Generic validation error. */ if (errorIdx == 0 || errorIdx >= count) { LOG(V4L2, Error) << "Unable to read controls: " << strerror(-ret); return {}; } /* A specific control failed. */ LOG(V4L2, Error) << "Unable to read control " << errorIdx << ": " << strerror(-ret); count = errorIdx - 1; ret = errorIdx; } updateControls(&ctrls, v4l2Ctrls, count); return ctrls; } /** * \brief Write controls to the device * \param[in] ctrls The list of controls to write * * This method writes the value of all controls contained in \a ctrls, and * stores the values actually applied to the device in the corresponding * \a ctrls entry. * * If any control in \a ctrls is not supported by the device, is disabled (i.e. * has the V4L2_CTRL_FLAG_DISABLED flag set), is read-only, if any other error * occurs during validation of the requested controls, no control is written and * this method returns -EINVAL. * * If an error occurs while writing the controls, the index of the first * control that couldn't be written is returned. All controls below that index * are written and their values are updated in \a ctrls, while all other * controls are not written and their values are not changed. * * \return 0 on success or an error code otherwise * \retval -EINVAL One of the control is not supported or not accessible * \retval i The index of the control that failed */ int V4L2Device::setControls(ControlList *ctrls) { unsigned int count = ctrls->size(); if (count == 0) return 0; struct v4l2_ext_control v4l2Ctrls[count]; memset(v4l2Ctrls, 0, sizeof(v4l2Ctrls)); unsigned int i = 0; for (auto &ctrl : *ctrls) { unsigned int id = ctrl.first; const auto iter = controls_.find(id); if (iter == controls_.end()) { LOG(V4L2, Error) << "Control " << utils::hex(id) << " not found"; return -EINVAL; } v4l2Ctrls[i].id = id; /* Set the v4l2_ext_control value for the write operation. */ ControlValue &value = ctrl.second; switch (iter->first->type()) { case ControlTypeInteger64: v4l2Ctrls[i].value64 = value.get<int64_t>(); break; case ControlTypeByte: { if (!value.isArray()) { LOG(V4L2, Error) << "Control " << utils::hex(id) << " requires an array value"; return -EINVAL; } Span<uint8_t> data = value.data(); v4l2Ctrls[i].p_u8 = data.data(); v4l2Ctrls[i].size = data.size(); break; } default: /* \todo To be changed to support strings. */ v4l2Ctrls[i].value = value.get<int32_t>(); break; } i++; } struct v4l2_ext_controls v4l2ExtCtrls = {}; v4l2ExtCtrls.which = V4L2_CTRL_WHICH_CUR_VAL; v4l2ExtCtrls.controls = v4l2Ctrls; v4l2ExtCtrls.count = count; int ret = ioctl(VIDIOC_S_EXT_CTRLS, &v4l2ExtCtrls); if (ret) { unsigned int errorIdx = v4l2ExtCtrls.error_idx; /* Generic validation error. */ if (errorIdx == 0 || errorIdx >= count) { LOG(V4L2, Error) << "Unable to set controls: " << strerror(-ret); return -EINVAL; } /* A specific control failed. */ LOG(V4L2, Error) << "Unable to set control " << errorIdx << ": " << strerror(-ret); count = errorIdx - 1; ret = errorIdx; } updateControls(ctrls, v4l2Ctrls, count); return ret; } /** * \brief Perform an IOCTL system call on the device node


context:
space:
mode: