diff options
| author | Niklas Söderlund <niklas.soderlund@ragnatech.se> | 2020-06-29 17:14:13 +0200 |
|---|---|---|
| committer | Niklas Söderlund <niklas.soderlund@ragnatech.se> | 2020-07-03 00:10:04 +0200 |
| commit | c3648da6e9569ce43bd4bfdf4195681e47a7919c (patch) | |
| tree | 0a40d30f6ce31b018d98ab762b901f927881da4f /src | |
| parent | 8e137b08194ea73c63832750af5ad2930688aa8a (diff) | |
libcamera: ipu3: Make it easier to read when a request may be completed
It's confusing to read the code and understand that a request is only
completed before being processed by the ImgU if it only contains a
single RAW buffer. Add a boolean variable with a explanatory name to
make this clearer, no functional change.
Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Diffstat (limited to 'src')
| -rw-r--r-- | src/libcamera/pipeline/ipu3/ipu3.cpp | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp index 1bdad209..958d8362 100644 --- a/src/libcamera/pipeline/ipu3/ipu3.cpp +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp @@ -874,10 +874,12 @@ void IPU3CameraData::cio2BufferReady(FrameBuffer *buffer) * If the request contains a buffer for the RAW stream only, complete it * now as there's no need for ImgU processing. */ - if (request->findBuffer(&rawStream_) && - pipe_->completeBuffer(camera_, request, buffer)) { - pipe_->completeRequest(camera_, request); - return; + if (request->findBuffer(&rawStream_)) { + bool isComplete = pipe_->completeBuffer(camera_, request, buffer); + if (isComplete) { + pipe_->completeRequest(camera_, request); + return; + } } imgu_->input_->queueBuffer(buffer); |