diff options
| author | Nicholas Roth <nicholas@rothemail.net> | 2022-10-30 18:05:00 -0500 |
|---|---|---|
| committer | Jacopo Mondi <jacopo@jmondi.org> | 2022-12-09 08:57:41 +0100 |
| commit | 21c049cbcb66354867712825d642bd9fc6977015 (patch) | |
| tree | 5164fe2d1d424e77889d4d8eaf20c1dd61475d84 /src | |
| parent | 5d6dc03bb310a4618e56579eea510d38bd15c830 (diff) | |
ipa: libcamera: add support for ov8858 sensor
Currently, libcamera does not have information for the ov8858 sensor
used in the PinePhone Pro, a phone designed to run Linux.
This commit adds metadata, especially that sensor gain is reported and
set in 1/16 discrete increments.
For more information, see "5.8 manual exposure compensation/ manual
gain compensation" in [0] and the driver in [1].
[0] http://www.ahdsensor.com/uploadfile/202008/55322e75316871.pdf
[1] https://github.com/megous/linux/blob/orange-pi-5.19/drivers/media/i2c/ov8858.c
Signed-off-by: Nicholas Roth <nicholas@rothemail.net>
Diffstat (limited to 'src')
| -rw-r--r-- | src/ipa/libipa/camera_sensor_helper.cpp | 11 | ||||
| -rw-r--r-- | src/libcamera/camera_sensor_properties.cpp | 14 |
2 files changed, 25 insertions, 0 deletions
diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp index 35056bec..f2ace261 100644 --- a/src/ipa/libipa/camera_sensor_helper.cpp +++ b/src/ipa/libipa/camera_sensor_helper.cpp @@ -476,6 +476,17 @@ public: }; REGISTER_CAMERA_SENSOR_HELPER("ov5693", CameraSensorHelperOv5693) +class CameraSensorHelperOv8858 : public CameraSensorHelper +{ +public: + CameraSensorHelperOv8858() + { + gainType_ = AnalogueGainLinear; + gainConstants_.linear = { 1, 0, 0, 128 }; + } +}; +REGISTER_CAMERA_SENSOR_HELPER("ov8858", CameraSensorHelperOv8858) + class CameraSensorHelperOv8865 : public CameraSensorHelper { public: diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp index e5f27f06..49867c74 100644 --- a/src/libcamera/camera_sensor_properties.cpp +++ b/src/libcamera/camera_sensor_properties.cpp @@ -146,6 +146,20 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen */ }, } }, + { "ov8858", { + .unitCellSize = { 1120, 1120 }, + .testPatternModes = { + { controls::draft::TestPatternModeOff, 0 }, + { controls::draft::TestPatternModeColorBars, 1 }, + /* + * No best corresponding test pattern for: + * 1: "Vertical Color Bar Type 1", + * 2: "Vertical Color Bar Type 2", + * 3: "Vertical Color Bar Type 3", + * 4: "Vertical Color Bar Type 4" + */ + }, + } }, { "ov8865", { .unitCellSize = { 1400, 1400 }, .testPatternModes = { |