pipeline: raspberrypi: rpi_stream: Set invalid buffer to id == 0

At present, the RPiStream buffer ids == -1 indicates an invalid value.
As a simplification, use id == 0 to indicate an invalid value. This
allows for better code readability.

As a consequence of this, use unsigned int for the buffer id values.

Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

1 files changed, 3 insertions, 3 deletions

diff --git a/src/libcamera/pipeline/rpi/vc4/raspberrypi.cpp b/src/libcamera/pipeline/rpi/vc4/raspberrypi.cpp
index af464d15..96749c0d 100644
--- a/src/libcamera/pipeline/rpi/vc4/raspberrypi.cpp
+++ b/src/libcamera/pipeline/rpi/vc4/raspberrypi.cpp
@@ -1210,7 +1210,7 @@ int PipelineHandlerRPi::queueRequestDevice(Camera *camera, Request *request)
 			continue;
 
 		FrameBuffer *buffer = request->findBuffer(stream);
-		if (buffer && stream->getBufferId(buffer) == -1) {
+		if (buffer && !stream->getBufferId(buffer)) {
 			/*
 			 * This buffer is not recognised, so it must have been allocated
 			 * outside the v4l2 device. Store it in the stream buffer list
@@ -2042,7 +2042,7 @@ void RPiCameraData::unicamBufferDequeue(FrameBuffer *buffer)
 
 	for (RPi::Stream &s : unicam_) {
 		index = s.getBufferId(buffer);
-		if (index != -1) {
+		if (index) {
 			stream = &s;
 			break;
 		}
@@ -2098,7 +2098,7 @@ void RPiCameraData::ispOutputDequeue(FrameBuffer *buffer)
 
 	for (RPi::Stream &s : isp_) {
 		index = s.getBufferId(buffer);
-		if (index != -1) {
+		if (index) {
 			stream = &s;
 			break;
 		}