diff options
author | Jacopo Mondi <jacopo@jmondi.org> | 2020-07-07 16:48:41 +0200 |
---|---|---|
committer | Jacopo Mondi <jacopo@jmondi.org> | 2020-08-03 11:16:17 +0200 |
commit | e0f8ce8454764ed27d5b1c2fcf22383f67def36b (patch) | |
tree | 6bd8df9986b73e487f3739bb32ec009a91ac471b /src/gstreamer/gstlibcamera.cpp | |
parent | 420d5b23a78a8b19bd8d52dd0cf76ed01da5f07e (diff) |
libcamera: ipu3: Adjust and assign streams in validate()
Remove the adjustStream() and assignStream() methods, and perform stream
adjustment and assignment while iterating the StreamConfiguration
items.
The adjustStream() implementation had some arbitrary assumption, like
the main output having to be as large as the sensor resolution, and did
not take into account the different alignment requirements between the
main output and the viewfinder output.
The assignStream() implementation also assumes only full-size streams
can be produced by the main output, and having it as a separate function
prevents adjusting streams according to which output they are assigned.
Blend the two implementation in a single loop and perform the required
stream adjustment and assignment in one go.
As streams are now assigned at validate() time, remove the same
operation from the configure() function.
Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
Diffstat (limited to 'src/gstreamer/gstlibcamera.cpp')
0 files changed, 0 insertions, 0 deletions