summaryrefslogtreecommitdiff
path: root/src/cam/options.h
diff options
context:
space:
mode:
authorJacopo Mondi <jacopo@jmondi.org>2019-02-12 21:48:10 +0100
committerJacopo Mondi <jacopo@jmondi.org>2019-02-14 05:31:23 +0100
commitddcd8ebb3de0d5938b59eb62b9cf2e5bc430d820 (patch)
treee74d7c79ad01d24ea5814f447757df1361e0a1d7 /src/cam/options.h
parentfea6dc9365c3793308e32f2cf73fafd94e144dd1 (diff)
libcamera: device_enumerator: Remove move() on search() return
Remove the std::move() call on the shared_ptr<MediaDevice *> returned by the search() method and remove the std::move() call on temporary return value in pipeline handlers that use the method. Thanks to copy elision, the regular constructor of the newly created object is called, avoiding un-necessary copies. Furthermore, the use of std::move() in the return and assignment statements prevents the compiler from performing copy elision, forcing it to generate two sequences of un-necessary calls to the class' move constructor and destructor. Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
Diffstat (limited to 'src/cam/options.h')
0 files changed, 0 insertions, 0 deletions